MAGECLOUD-343: Method for exporting a DB Backup of production site #94
Conversation
…-343 # Conflicts: # src/App/Container.php # src/Application.php # src/Test/Unit/ApplicationTest.php
src/Process/DbDump/DbDump.php
Outdated
| } | ||
| fclose($lockFileHandle); | ||
| } catch (\Exception $e) { | ||
| $this->logger->info('ERROR: ' . $e->getMessage()); |
There was a problem hiding this comment.
Here you can use ->error method instead of ->info to avoid adding 'ERROR: ' to log message
src/Process/DbDump/DbDump.php
Outdated
| $errors = $this->shell->execute('bash -c "set -o pipefail; ' . $command . '"'); | ||
|
|
||
| if ($errors) { | ||
| $this->logger->info('Error has occurred during mysqldump'); |
There was a problem hiding this comment.
Here you can increase log level to error to emphasize message value
|
|
||
| $this->process->execute(); | ||
|
|
||
| // As we do not know the dump file name before running script, |
There was a problem hiding this comment.
You can use \phpmock\phpunit\PHPMock class for mocking php functions. Please look into StaticContentCleanerTest class.
shiftedreality
added
Progress: testing in progress
|
@NadiyaS please add link to task MAGECLOUD-343 |
|
QA approved |
shiftedreality
added
Progress: accept
…-343 # Conflicts: # src/App/Container.php
src/Process/DbDump/DbDump.php
Outdated
| */ | ||
| private function getCommand() | ||
| { | ||
| $command = "timeout 3600 mysqldump -h {$this->connectionData->getHost()} -P {$this->connectionData->getPort()}" |
There was a problem hiding this comment.
Ok, I'll move this value to constant
| * | ||
| * @return string | ||
| */ | ||
| public function getHost(); |
There was a problem hiding this comment.
Add PHP strict types (:int, :string, etc to all methods you introduced)
There was a problem hiding this comment.
we cannot add strict types to all methods as some of them can return several types. Also, we need to review class Environment which returns values of environment variables, because now almost all methods return string type even if the variable does not exist. And these changes may affect current Interface as it uses Environment class
|
Will be re-worked a bit. After discussion agreed to add / remove some items. |
shiftedreality
added
Progress: on hold
YPyltiai
added
Release: 2002.0.5
MAGECLOUD-343 Method for exporting a DB Backup of production site
Description
New CLI command to create DB dump on CLOUD
Zephyr Tests
Contribution checklist