MAGECLOUD-1193: Enable strict errors #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshmyheliuk
reviewed
Oct 31, 2017
src/App/ErrorHandler.php
Outdated
| * @return bool | ||
| * @throws \Exception | ||
| */ | ||
| public function handler($errorNo, $errorStr, $errorFile, $errorLine) |
There was a problem hiding this comment.
I think this method should be named as "handle"
oshmyheliuk
reviewed
Oct 31, 2017
src/App/ErrorHandler.php
Outdated
|
|
||
| $msg = isset($this->errorPhrases[$errorNo]) ? $this->errorPhrases[$errorNo] : "Unknown error ({$errorNo})"; | ||
| $msg .= ": {$errorStr} in {$errorFile} on line {$errorLine}"; | ||
| throw new \Exception($msg); |
There was a problem hiding this comment.
Why notice or strict should throw an exception?
There was a problem hiding this comment.
Fail fast principle
shiftedreality
requested review from
ngeron,
michaelcasey316,
billygilbert and
JacobBrownAustin
oshmyheliuk
approved these changes
Oct 31, 2017
shiftedreality
added
Progress: accept
|
QA check is not needed for this PR. |
billygilbert
approved these changes
Oct 31, 2017
kandy
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://magento2.atlassian.net/browse/MAGECLOUD-1193
Description
This PR add strict errors handling to avoid dummy errors.
Contribution checklist