Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGECLOUD-3611: Multi-threaded SCD Doesn’t Work as Expected #530

Merged
merged 6 commits into from
Jun 3, 2019
Merged

MAGECLOUD-3611: Multi-threaded SCD Doesn’t Work as Expected #530

merged 6 commits into from
Jun 3, 2019

Conversation

NadiyaS
Copy link
Contributor

@NadiyaS NadiyaS commented May 31, 2019

Description

  • Customers now observe issues with SCD, which are common across multiple projects

Fixed Issues (if relevant)

  1. [ECE-Tools] Multi-threaded SCD Doesn’t Work as Expected #503: [ECE-Tools] Multi-threaded SCD Doesn’t Work as Expected
  2. MAGECLOUD-3611

Manual testing scenarios

  1. prepare configurations to make SCD runs with 4 and more threads
  2. SCD_THREADS: 4
    SCD_MATRIX:
    "magento/backend":
    language:
    - en_US
    - fr_FR
    - ja_JP
    - sk_SK
    - nb_NO
    - en_GB
    - uk_UA
    - es_ES
    - lv_LV
    - it_IT
    "magento/luma":
    language:
    - en_US
    - fr_FR
    - ja_JP
    - sk_SK
    - nb_NO
    - en_GB
    - uk_UA
    - es_ES
    - lv_LV
  3. SCD should be run as on build as on deploy phase

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@NadiyaS NadiyaS mentioned this pull request May 31, 2019
Closed
4 tasks
shiftedreality
shiftedreality suggested changes May 31, 2019
View reviewed changes
patches.json Outdated
@@ -159,6 +159,12 @@
"2.1.4 - 2.1.17": "MC-5964__preauth_sql__2.1.4.patch",
"2.2.0 - 2.2.7": "MC-5964__preauth_sql__2.2.0.patch",
"2.3.0": "MC-5964__preauth_sql__2.3.0.patch"
},
"Multi-thread SCD": {
"2.2.0 - 2.2.3": "MAGECLOUD_3611_multi_thread_scd__2.2.0.patch",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use common format MAGECLOUD-3611__

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, did not notice that.
Fixed

@NadiyaS NadiyaS requested review from BaDos and oshmyheliuk May 31, 2019 20:23
@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality shiftedreality added the Progress: accept PR/issue status label Jun 3, 2019
@shiftedreality shiftedreality merged commit 9aa217b into develop Jun 3, 2019
@ghost
Copy link

ghost commented Jun 3, 2019

Hi @NadiyaS, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shiftedreality shiftedreality deleted the MAGECLOUD-3611 branch June 3, 2019 13:19
@YPyltiai YPyltiai mentioned this pull request Jun 3, 2019
Closed
@YPyltiai YPyltiai added the Release: 2002.0.20 ECE-Tools Release label Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftedreality shiftedreality shiftedreality approved these changes

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

@BaDos BaDos Awaiting requested review from BaDos

Assignees
No one assigned
Labels
Progress: accept PR/issue status Release: 2002.0.20 ECE-Tools Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NadiyaS @andriyShevtsov @shiftedreality @oshmyheliuk @YPyltiai