MAGECLOUD-1618: Temporary Workaround to Clean-up "disable_locking" Parameter #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsche
reviewed
Jan 24, 2018
|
|
||
| if (isset($config['session']['redis']['disable_locking'])) { | ||
| $this->logger->info('Removing disable_locking env.php.'); | ||
| unset($config['session']['redis'] ['disable_locking']); |
There was a problem hiding this comment.
What's that itty bitty space doing there?
bbatsche
approved these changes
Jan 24, 2018
JacobBrownAustin
approved these changes
Jan 24, 2018
billygilbert
added
Progress: testing in progress
michaelcasey316
approved these changes
Jan 24, 2018
|
Tested with version 2.2.0 and 2.2.2, executed without any issues. QA passed. |
shiftedreality
changed the title
oshmyheliuk
approved these changes
Jan 25, 2018
|
Fix is minor. Architect approve not needed. |
mveeramneni
added
Progress: accept
YPyltiai
added
Release: 2002.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing disable_locking parameter if present in env.php
Fixed Issues (if relevant)
Zephyr Tests
Contribution checklist