MAGECLOUD-1582: The "disable_locking" parameter breaks 2.2.0 and doesn't required in >=2.2.2

[oshmyheliuk]

Description

Fixed Issues (if relevant)

https://magento2.atlassian.net/browse/MAGECLOUD-1582

Zephyr Tests

1. ...

Relate pull request

https://github.com/magento/ece-patches/pull/31

Contribution checklist

• Pull request has a meaningful description of its purpose
• Pull request was approved by architect
• Pull request was approved by QA member
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[shiftedreality]

This won’t work, because repo.magento.com is not available outside of metpackage. This should be fixed in other way, or constraints in matapackage bumped.

[shiftedreality]

You can use MagentoVersion to correctly handle this edge case

[andriyShevtsov]

Need to check with version 2.2.2, 2.2.1, 2.2.0.
Scenario is the next:

1. create a product as Admin user
2. create a customer
3. Add product to Cart
4. Checkout
   Expected result: time significantly decreased compared with version without fix.

[andriyShevtsov]

Also the same things should be tested with upgrade:
from 2.2.0 to 2.2.1
from 2.2.1 to 2.2.2

[mveeramneni]

Test failed with above mentioned error

[billygilbert]

@mveeramneni Identified an issue during QA with the pull request for ECE-Patches. I've noted it in the PR magento/ece-patches#31

[oshmyheliuk]

Bug about patch applying was fixed, sorry it was my fault, I forgot to change the name of the patch.

[oshmyheliuk]

@shiftedreality I don't understand why this shouldn't work? We just apply patch for two version of magento/framework 101.0.0 and 101.0.1

[shiftedreality]

Sasha, I was taking about changes in composer.json. Good to see you removed it

[andriyShevtsov]

QA passed