MAGECLOUD-1332: Add ability to configure cron_consumers_runner via an environment variable #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2017 14:21
… environment variable
… environment variable
shiftedreality
approved these changes
Nov 28, 2017
NadiyaS
approved these changes
Nov 28, 2017
NadiyaS
reviewed
Nov 28, 2017
| $config = $this->configReader->read(); | ||
| $cronConsumersRunnerConfig = new Repository($this->environment->getCronConsumersRunner()); | ||
|
|
||
| $config['cron_consumers_runner'] = [ |
There was a problem hiding this comment.
what if env.php already has configurations for this section?
There was a problem hiding this comment.
We set configuration only from ENV variable.
NadiyaS
suggested changes
Nov 28, 2017
| $cronConsumersRunnerConfig = new Repository($this->environment->getCronConsumersRunner()); | ||
|
|
||
| $config['cron_consumers_runner'] = [ | ||
| 'cron_run' => $cronConsumersRunnerConfig->get('cron_run') === 'true', |
There was a problem hiding this comment.
if CRON_CONSUMERS_RUNNER variable does not exist you don't need to set these values, because in this case you need to use Magento default values (they can be changed)
There was a problem hiding this comment.
We disable this consumers runner by default on the Cloud.
NadiyaS
approved these changes
Nov 28, 2017
andriyShevtsov
approved these changes
Nov 29, 2017
|
QA approved |
shiftedreality
added
Progress: accept
YPyltiai
added
Release: 2002.0.5
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Magento allows to configure cron_consummers_runner via app/etc/env.php
We added opportunity to configure cron job cron_consummers_runner via an environment variable CRON_CONSUMERS_RUNNER.
Fixed Issues (if relevant)
https://magento2.atlassian.net/browse/MAGECLOUD-1332
Zephyr Tests
https://jira.corp.magento.com/browse/MAGETWO-84602
Contribution checklist