This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info about optimized realpath_cache_settings #7939
Add info about optimized realpath_cache_settings #7939
Changes from 1 commit
4449c50
200ec4e
a43322e
1de799b
6c3246a
ae9bca2
07b408d
39c70cc
68b63c2
adadd7b
58d4955
8fd265d
f2ae8e1
019fbdf
adfb983
e0e63be
5f8aca1
77f9c43
b810dd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these updates and reverted to original headings from the nested list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Extension list has been repeated in the Default Extensions list
Also as the Optional list is much longer that the other, the DE & RE list float in the middle of the table. Can these be aligned to the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Redid the table to begin with required extensions, followed by default and optional extensions. I also removed the default extensions from the optional list, and updated the Optional descriptions summary to state that the default extensions can be disabled.-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid the list is still incorrect.
The following extensions are required but appear in the optional list -
bcmath
gd
intl
pdo_mysql
soap
xsl
zip
(https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements-tech.html)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
sockets
extension also became required in Magento 2.4.0 and higher btw. Should also be included in https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements-tech.html in my opinion!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hostep I updated the PHP settings topic to add a note about the ext-sockets extension that was in the 2.3 version of the topic:
In the php-settings topic, the list of required extensions is generated in this file: https://github.com/magento/devdocs/blob/master/src/_includes/install/php-extensions-template.md, but
ext-sockets
is not included. I think we should open a separate issue to address this, and request assistance from @dshevtsov.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored the original content from this topic. I realized that I was conflating enable and disable extensions with install and uninstall. In the .magento.app.yaml file, which is the subject of this topic, you only enable and disable extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meker12: we already kind-of had an issue for this, but it was closed unfortunately: #7568 (comment), should I create a new issue for this? I know colleagues of yours are already aware of the issue for many months (internal ticket DOC-80), but maybe we need an official public ticket to track this, otherwise it might be forgotten...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hostep Thanks for the context about the ext-sockets extension. It's useful that the current guide now includes a specific mention of the ext-sockets extension, and why you need it. Will follow up on our internal ticket to understand the best information to provide about this extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hostep the DOC-80 is closed. It was mostly focused on the Packages topics. As it appeared, it's impossible to get accurate information about PHP versions from the Composer files. I hope that it is still possible for the list of extensions. Please open an issue for this with your recent suggestions (#7568, #7398) and assign it to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dshevtsov, done: #7960 (but I can't assign you)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is best to clarify here. I don't know why any extension from the Required column would be duplicated anywhere else because you note that they cannot be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored original column headings. My proposed updates didn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our support site is recommending something different. Is 756 the minimum? I know I have seen different values for this, and mine is set to 2G.
https://support.magento.com/hc/en-us/articles/360034599631-PHP-settings-errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no recommended minimum, this has been discussed many times before, 768M and 2G are ridiculously high. We are running M2 shops on 192M or 256M without issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be removed now that the web set up wizard was removed in Magento 2.4.0?