Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Url Rewrite Step" data source pagination #683

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

therool
Copy link
Contributor

@therool therool commented Apr 18, 2019

Description

Fixed Issues (if relevant)

  1. Incorrect url rewrite record pagination #682: Incorrect url rewrite record pagination

Manual testing scenarios

  1. Set bulk_size property to 10
  2. Have at least 30 url rewrites in magento 1
  3. Add
if ($documentName === 'core_url_rewrite') {
	var_dump([
		$pageNumber,
		$select->__toString()
	]);
}

to Adapter\Mysql::loadPage method before $result = $this->resourceAdapter->fetchAll($select) to see the pagination queries

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@magento-cicd2
Copy link

magento-cicd2 commented Apr 18, 2019

CLA assistant check
All committers have signed the CLA.

@victor-v-rad victor-v-rad merged commit c0dbee5 into magento:2.3-develop Apr 23, 2019
@ghost
Copy link

ghost commented Apr 23, 2019

Hi @therool, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants