Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate ignore mapping of 'admin_role' and 'admin_rule' document_rules. #549

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Removed duplicate ignore mapping of 'admin_role' and 'admin_rule' document_rules. #549

merged 1 commit into from
Jul 17, 2018

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Jul 6, 2018 •
edited
Loading

Related to my previous PR: #488

Fixed: #554

Found two duplicate nodes to ignore admin_role and admin_rule tables in the source node in the map.xml.
I fixed this issue for commerce-to-commerce platform mapping files(map.xml).

        <document_rules>
            <ignore>
                <document>admin_role</document>
            </ignore>
            <ignore>
                <document>admin_rule</document>
            </ignore>
            <ignore>
                <document>admin_role</document>
            </ignore>
            <ignore>
                <document>admin_rule</document>
            </ignore>
</document_rules>
.
.
.
</source>```

@magento-cicd2
Copy link

magento-cicd2 commented Jul 6, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@victor-v-rad victor-v-rad mentioned this pull request Jul 16, 2018
Closed
@victor-v-rad
Copy link
Collaborator

Thank you @sanganinamrata for fixing it. Internal ticket MAGETWO-93228 to process it

@victor-v-rad victor-v-rad mentioned this pull request Jul 16, 2018
Merged
@victor-v-rad victor-v-rad reopened this Jul 16, 2018
@victor-v-rad victor-v-rad merged commit b63cb11 into magento:2.2-develop Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanganinamrata @magento-cicd2 @victor-v-rad