Attributes with dash in attribute codes give errors

[peterjaap]

Preconditions

1. Magento 2.2.5
2. DMT 2.2.5
3. An attribute with attribute code containing a dash (in my case category-extra-image)

Steps to reproduce

1. bin/magento migrate:data -r vendor/magento/data-migration-tool/etc/opensource-to-opensource/1.9.3.9/config.xml.dist -a

Expected result

1. The attribute should be migrated

Actual result

  [Exception]                                                                                                                                          
  Notice: Undefined index: 3-category in /data/client/magento2/vendor/magento/data-migration-tool/src/Migration/Step/Eav/Data.php on line 915  

Proposed solution

Limit the number of elements explode() returns to 2, causing the remainder of the attribute code to remain intact. So change line 909 to;

            list($entityTypeId, $attributeCodeDest) = explode('-', $keyOld, 2);

and line 916 to;

                list($entityTypeIdDest, $attributeCodeDest) = explode('-', $keyDest, 2);

This fixes the error and the attribute migrates correctly.

[victor-v-rad]

Hi @peterjaap

Sorry for late reply. Thank you for reporting this issue. Your solution looks good. Internal ticket MAGETWO-94410 to process it.