Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GraphQL endpoint for single product retrieval #12

Open
kokoc opened this issue May 6, 2020 · 8 comments · May be fixed by magento/magento2#28316
Open

New GraphQL endpoint for single product retrieval #12

kokoc opened this issue May 6, 2020 · 8 comments · May be fixed by magento/magento2#28316

Comments

@kokoc
Copy link
Member

kokoc commented May 6, 2020

Introduce new GraphQL query for serving Product Details Page

See details in magento/architecture#368 PR description

AC:

  • New query for PDP is introduced
  • New query returns ProductInterface wrapped in ProductOutput type(for extensibility purposes)
  • New query works on Magento monolith application
@serhiyzhovnir
Copy link

Hi @kokoc
@kokoc The PR that creates a new endpoint for getting a single product by ID.
Could you, please, review the PR?
Thanks!

@mslabko
Copy link
Member

mslabko commented Jun 18, 2020

@nrkapoor I believe we should move this issue to GraphQL project.

@DrewML
Copy link

DrewML commented Jun 22, 2020

New query works on both: Magento & Catalog Storefront

What's the difference between "Magento" and "Catalog Storefront"?

@mslabko
Copy link
Member

mslabko commented Jun 23, 2020

@DrewML "Magento" has a lot of meanings, including "Catalog Storefront". It may be "B2C", "Community edition", "B22"... But first of all this is our product ;)

"Catalog storefront" is just a set of extensions (modules) that bring new behavior to Magento and in current state is in a deep development phase

@DrewML
Copy link

DrewML commented Jun 23, 2020

"Magento" has a lot of meanings, including "Catalog Storefront". It may be "B2C", "Community edition", "B22"... But first of all this is our product ;)

Right, you're confirming that the acceptance criteria is ambiguous. "Magento" is a brand, I'm trying to understand what we really mean (assuming PHP monolith?)

@mslabko
Copy link
Member

mslabko commented Jun 23, 2020

I think you need to ask in some general channel - you will have 100500 definitions :)

From my understanding, it depends on the conversation context. In terms of "Storefront" topic (again - need definitions, I mean SF Application which we are working on) by "Magento" we often mean our produce as backend system / PIM. But sometimes we can mean just a vanilla set of core modules... So yeah we need to have ONE glossary and use the same definitions

@DrewML
Copy link

DrewML commented Jun 23, 2020

@mslabko not talking about in general here, this is about this specific story and its acceptance criteria.

Perhaps it's better to rephrase: instead of "what's the difference," let's go with "which systems does this query need to work in"

@mslabko
Copy link
Member

mslabko commented Jun 23, 2020

@DrewML I believe this task must be split into 2 tasks. Current PR in progress should go to "Magento" - magneto/magento2ce repo

And after implementation, we can handle second criteria in a separate task for CatalogStorefront.
CC: @kokoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants