Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used In Content Entities Filters #1593

Merged
merged 15 commits into from
Jul 20, 2020
Merged

Used In Content Entities Filters #1593

merged 15 commits into from
Jul 20, 2020

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Jul 10, 2020 •
edited
Loading

Fixed Issues (if relevant)

Fixes #1465 Introduce Used In Products filter
Fixes #1466 Introduce Used In Categories filter
Fixes #1467 Introduce Used In Pages filter
Fixes #1468 Introduce Used In Blocks filter

Covered with MFTF tests

Depends on: https://github.com/magento/magento2-infrastructure/pull/1242

@sivaschenko sivaschenko changed the title Introduced Used In Products filter Used In Content Entities Filters Jul 12, 2020
@sivaschenko sivaschenko requested a review from Nazar65 July 13, 2020 12:06
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko sivaschenko mentioned this pull request Jul 13, 2020
Closed
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@gabrieldagama gabrieldagama self-assigned this Jul 14, 2020
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko sivaschenko marked this pull request as ready for review July 14, 2020 14:28
gabrieldagama
gabrieldagama reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sivaschenko, thanks for the PR, it looks great! Please follow some small comments below:

MediaGalleryCmsUi/Controller/Adminhtml/Page/Search.php Outdated Show resolved Hide resolved
MediaGalleryCmsUi/Controller/Adminhtml/Block/Search.php Outdated Show resolved Hide resolved
MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/Entity.php
class Entity implements CustomFilterInterface
{
private const TABLE_ALIAS = 'main_table';
private const TABLE_MEDIA_CONTENT_ASSET = 'media_content_asset';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are depending on the content table here, shouldn't we add MediaContent implementation as dependency on MediaGalleryUi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static test says no (and it would probably fail if we add it)

...CatalogUi/Test/Mftf/ActionGroup/AdminMediaGalleryAddImageToProductDescriptionActionGroup.xml Outdated Show resolved Hide resolved
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

Thanks for the review @gabrieldagama ! The changes have been applied

@sivaschenko
Copy link
Member Author

@magento run all tests

Nazar65
Nazar65 previously approved these changes Jul 15, 2020
View reviewed changes
gabrieldagama
gabrieldagama previously approved these changes Jul 16, 2020
View reviewed changes
@sivaschenko sivaschenko dismissed stale reviews from gabrieldagama and Nazar65 via 87e3463 July 17, 2020 06:04
@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko sivaschenko merged commit 544ad54 into magento:2.0-develop Jul 20, 2020
@ghost
Copy link

ghost commented Jul 20, 2020

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama left review comments

@Nazar65 Nazar65 Nazar65 left review comments

Assignees

@sivaschenko sivaschenko

@gabrieldagama gabrieldagama

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sivaschenko @Nazar65 @gabrieldagama