Introduce used in filter #1531

ghost · 2020-06-25T13:23:24Z

Description (*)

Add Used In filter to the media gallery to allow the user to filter by the area where the images are used in: pages, categories, blocks, products.

Fixed Issues (if relevant)

Fixes Introduce Used In filter #1462: Introduce Used In filter

Manual testing scenarios (*)

in order to test the search must put images on these area pages, categories, blocks, products.

Admin > content > media gallery - click filter button and select your search.

…lery to allow the user to filter by the area where the images are used in: pages, categories, blocks, products

ghost · 2020-06-25T13:24:08Z

@magento run all tests

sivaschenko · 2020-06-26T11:03:12Z

MediaGalleryUi/Model/GetDetailsByAssetId.php

@@ -85,6 +85,7 @@ public function execute(int $assetId): array
            'image_url' => $this->getUrl($asset->getPath()),
            'title' => $asset->getTitle(),
            'path' => $asset->getPath(),
+            'description' => $asset->getDescription(),


Looks like this PR contains the changes from #1512. Can you please ensure each PR contains only the changes related to the task

sivaschenko

Thanks for the PR @gregbalonzo ! The implementation looks good, however, it should be moved to the MediaGalleryUi module

sivaschenko · 2020-06-26T13:13:37Z

AdobeStockImageAdminUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/EntityType.php

+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\AdobeStockImageAdminUi\Model\SearchCriteria\CollectionProcessor\FilterProcessor;


Please move the files to MediaGalleryUi module.

I tried moving the file AdobeStockImageAdminUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/EntityType.php
to
stock-integration/MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/
i cannot get to work

I meant that all the implementation should be moved to MediaGalleryUi module, not just a single file (for sure, the namespaces should be changed accordingly).

Hi sergii, done moving the implementation MediaGalleryUi module

…leryUi

gabrieldagama · 2020-06-29T08:47:51Z

@magento run all tests

MediaGalleryUi/Ui/Component/Listing/Columns/Layout/Options.php

gabrieldagama · 2020-06-29T11:14:29Z

MediaGalleryUi/Ui/Component/Listing/Columns/Layout/Options.php

+     */
+    public function toOptionArray(): array
+    {
+        return [


Can we inject this array here via di.xml? That will allow other extensions to easily add their entity to this.

coderimus

Hi @gregbalonzo , thank you for your contribution. Please, check my suggestions below.

MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/EntityType.php

…Processor/EntityType.php Co-authored-by: Alexander Shkurko <[email protected]>

Co-authored-by: Gabriel da Gama <[email protected]>

…ave a description, eject into array filter name

ghost · 2020-06-30T06:19:23Z

@magento run all tests

coderimus · 2020-06-30T11:21:52Z

Hello @gregbalonzo ! Thank you for the provided changes. Please, fix the conflict at the image-details.html

ghost · 2020-06-30T12:31:09Z

@magento run all tests

This reverts commit 711765e.

…be-stock-integration into introduce-used-in-filter

chalov-anton

❌ QA Failed

Please observe the following points from less important to more important:

Since plural is used with Blocks, Categories, Products, please use plural for Pages also
there is a frontend issue when applying filters NOT from Standalone Media Gallery, for example from Catalog - Categories
if there is an image which is used in two entities, for example in Product and in Category, and both filters are applied - an Item (Magento\Framework\View\Element\UiComponent\DataProvider\Document) with the same ID "1" already exists. text is displayed

works properly when only one of the filters is applied

chalov-anton · 2020-07-03T10:45:01Z

Test on the Cucumber Studio - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4930844

gabrieldagama · 2020-07-06T09:08:25Z

@magento run all tests

gabrieldagama · 2020-07-06T11:02:21Z

@magento run all tests

chalov-anton · 2020-07-06T14:39:31Z

✔️ QA Passed

ghost · 2020-07-07T12:06:16Z

Hi @gregbalonzo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

#1462: Introduce Used In filter - Add Used In filter to the media gal…

227ec0f

…lery to allow the user to filter by the area where the images are used in: pages, categories, blocks, products

gabrieldagama self-assigned this Jun 25, 2020

m2-community-project bot added the Progress: review label Jun 25, 2020

sivaschenko requested changes Jun 26, 2020

View reviewed changes

m2-community-project bot assigned sivaschenko Jun 26, 2020

m2-community-project bot added Progress: changes requested and removed Progress: review labels Jun 26, 2020

killerboduk1 added 2 commits June 26, 2020 21:02

remove code from previous PR

711765e

remove code from previous PR

6312eb6

sivaschenko requested changes Jun 26, 2020

View reviewed changes

#1531: Introduce used in filter - move the implementation to MediaGal…

a1f72c7

…leryUi

gabrieldagama suggested changes Jun 29, 2020

View reviewed changes

coderimus suggested changes Jun 29, 2020

View reviewed changes

m2-community-project bot assigned coderimus Jun 29, 2020

killerboduk1 and others added 5 commits June 29, 2020 20:05

Update MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/Filter…

15af2d5

…Processor/EntityType.php Co-authored-by: Alexander Shkurko <[email protected]>

Update MediaGalleryUi/Ui/Component/Listing/Columns/Layout/Options.php

2c56458

Co-authored-by: Gabriel da Gama <[email protected]>

Update MediaGalleryUi/Ui/Component/Listing/Columns/Layout/Options.php

a1754b1

Co-authored-by: Gabriel da Gama <[email protected]>

#1531: Introduce Used In Filter - Add declare(strict_types=1);

d03f93b

#1531: Introduce used in filter - Resolve PR commented class should h…

f370615

…ave a description, eject into array filter name

Merge branch '2.0-develop' into introduce-used-in-filter

4082224

killerboduk1 added 2 commits June 30, 2020 21:53

Revert "remove code from previous PR"

28cf262

This reverts commit 711765e.

Merge branch 'introduce-used-in-filter' of github.com:gregbalonzo/ado…

787eddd

…be-stock-integration into introduce-used-in-filter

chalov-anton suggested changes Jul 2, 2020

View reviewed changes

m2-community-project bot assigned chalov-anton Jul 2, 2020

m2-community-project bot added Progress: changes requested and removed Progress: acceptance testing labels Jul 2, 2020

sivaschenko mentioned this pull request Jul 2, 2020

magento/adobe-stock-integration#1467: Introduce Used In Pages filter … #1546

Closed

#1531:Introduce used in filter - fix failed QA

48d0853

ghost dismissed stale reviews from coderimus and gabrieldagama via 48d0853 July 3, 2020 14:47

Added join processor back and fixed css

67b3b12

Fixed static tests

bc4b3b1

gabrieldagama previously approved these changes Jul 6, 2020

View reviewed changes

m2-community-project bot added Progress: acceptance testing and removed Progress: changes requested labels Jul 6, 2020

m2-community-project bot added Progress: ready for delivery and removed Progress: acceptance testing labels Jul 6, 2020

Corrected property name

274ff22

sivaschenko dismissed gabrieldagama’s stale review via 274ff22 July 7, 2020 12:05

Merge branch '2.0-develop' into introduce-used-in-filter

25703ff

sivaschenko merged commit 5738b5b into magento:2.0-develop Jul 7, 2020

m2-community-project bot removed the Progress: ready for delivery label Jul 7, 2020

sivaschenko mentioned this pull request Jul 7, 2020

[MFTF] Cover Used In Media Gallery filter with MFTF tests #1567

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce used in filter #1531

Introduce used in filter #1531

ghost commented Jun 25, 2020

ghost commented Jun 25, 2020

sivaschenko Jun 26, 2020 •

edited

Loading

sivaschenko left a comment

sivaschenko Jun 26, 2020

ghost Jun 26, 2020

sivaschenko Jun 26, 2020

ghost Jun 28, 2020

gabrieldagama commented Jun 29, 2020

gabrieldagama Jun 29, 2020

coderimus left a comment

ghost commented Jun 30, 2020

coderimus commented Jun 30, 2020

ghost commented Jun 30, 2020

chalov-anton left a comment

chalov-anton commented Jul 3, 2020 •

edited

Loading

gabrieldagama commented Jul 6, 2020

gabrieldagama commented Jul 6, 2020

chalov-anton commented Jul 6, 2020

ghost commented Jul 7, 2020

Introduce used in filter #1531

Introduce used in filter #1531

Conversation

ghost commented Jun 25, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

ghost commented Jun 25, 2020

sivaschenko Jun 26, 2020 • edited Loading

Choose a reason for hiding this comment

sivaschenko left a comment

Choose a reason for hiding this comment

sivaschenko Jun 26, 2020

Choose a reason for hiding this comment

ghost Jun 26, 2020

Choose a reason for hiding this comment

sivaschenko Jun 26, 2020

Choose a reason for hiding this comment

ghost Jun 28, 2020

Choose a reason for hiding this comment

gabrieldagama commented Jun 29, 2020

gabrieldagama Jun 29, 2020

Choose a reason for hiding this comment

coderimus left a comment

Choose a reason for hiding this comment

ghost commented Jun 30, 2020

coderimus commented Jun 30, 2020

ghost commented Jun 30, 2020

chalov-anton left a comment

Choose a reason for hiding this comment

chalov-anton commented Jul 3, 2020 • edited Loading

gabrieldagama commented Jul 6, 2020

gabrieldagama commented Jul 6, 2020

chalov-anton commented Jul 6, 2020

ghost commented Jul 7, 2020

sivaschenko Jun 26, 2020 •

edited

Loading

chalov-anton commented Jul 3, 2020 •

edited

Loading