Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce massaction mode for media gallery #1509

Merged
merged 31 commits into from
Jul 2, 2020
Merged

Introduce massaction mode for media gallery #1509

merged 31 commits into from
Jul 2, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jun 19, 2020 •
edited
Loading

Description (*)

whats left:

  1. Send request to deleting images ✔️
  2. Show count of selected images ✔️
  3. Correct styles to match mockups ✔️
  4. Switch to mass action mode by checkboxes ✔️
  5. On press cancel button terminate massaction mode ✔️

Fixed Issues (if relevant)

  1. Fixes Introduce massaction mode for image delete #1488: Introduce ability to switch to massaction mode in the media gallery
  2. Fixes Add ability to select images clicking on the image tile in the massaction mode #1516: Add ability to select images clicking on the image tile in the massaction mode
  3. Fixes Display content usage information for multiple assets during multiple delete #1513: Display content usage information for multiple assets during multiple delete

Manual testing scenarios (*)

  1. Open Media Gallery page or slide panel
  2. Click on massaction checkbox verify mass action mode activated
  3. Select images in different folder or pages -> assert selected count up to date with selected images.
  4. Click delete selected button
  5. Assert images deleted, assert massaction mode not active anymore
    Screenshot_2020-06-19 Manage Gallery Media Content Magento Admin(2)

@Nazar65 Nazar65 marked this pull request as draft June 19, 2020 15:40
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 19, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 20, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 20, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 20, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title [WIP] Introduce massaction mod for media gallery [WIP] Introduce massaction mode for media gallery Jun 20, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 20, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 20, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 22, 2020

@magento run all tests

sivaschenko
sivaschenko reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Nazar65 ! Added a couple of comments

MediaGalleryUi/Controller/Adminhtml/Image/Delete.php Outdated Show resolved Hide resolved
MediaGalleryUi/Controller/Adminhtml/Image/Delete.php Outdated Show resolved Hide resolved
MediaGalleryUi/view/adminhtml/web/js/grid/massactions.js Outdated Show resolved Hide resolved
@Nazar65
Copy link
Member Author

Nazar65 commented Jun 22, 2020

@magento run all tests

chalov-anton
chalov-anton suggested changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@chalov-anton chalov-anton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When an image is selected, two similar Delete Selected buttons are displayed
2delete selected

Please rename the Delete Selected… into Delete Images…
https://xd.adobe.com/view/0a8fc470-497b-4fd6-4043-62560c21d8db-7cbe/screen/4b2e4f6d-8b87-4c51-8161-be77b5add80a/Media-Gallery

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jun 30, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 1, 2020

Hi @chalov-anton i'v implemented the last issue on the "massaction mode story" could you please check the functionality now ?

@chalov-anton
Copy link
Contributor

chalov-anton commented Jul 1, 2020 •
edited
Loading

✔️ QA Passed

Great job 👍
The test on the Cucumber https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/3962787 (the test state is Complete)

@sivaschenko sivaschenko merged commit 19de047 into magento:2.0-develop Jul 2, 2020
@ghost
Copy link

ghost commented Jul 2, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko mentioned this pull request Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalov-anton chalov-anton chalov-anton requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@chalov-anton chalov-anton

Labels
MFTF tests MFTF tests coverage
Projects
None yet
Milestone
No milestone
4 participants
@Nazar65 @lenaorobei @chalov-anton @sivaschenko