#1440: create an endpoint for saving asset attributes #1506

joweecaquicla · 2020-06-18T18:29:30Z

Description (*)

This PR will implement the endpoint for saving asset attributes and it also includes a partial implementation of the Edit Image form. The 'Keywords' field will be implemented in a separate task.

Fixed Issues (if relevant)

Fixes Create an endpoint for saving asset attributes #1440: Create an endpoint for saving asset attributes
Fixes Add slide panel to the frontend for editing attributes #1441: Add slide panel to the frontend for editing attributes
Fixes [MFTF] Cover user set image description and sees it on image details #1529: [MFTF] Cover user set image description and sees it on image details

Manual testing scenarios (*)

Login to Admin panel
Open the media gallery. i.e. from the Catalog -> Category -> Content fieldset -> Select image from gallery
Choose an image to edit and click the three dots icon, and choose 'Edit'.
Edit Image Details slide panel will be opened and will allow you to edit the Title and Description of the image.
Click save after applying modifications.

…templates for edit image details modal and additional controllers

…set-attributes

…ent SaveDetails controller and modifications on script and templates for the edit image form

…ed SaveDetails controller and edit details form/slide panel

joweecaquicla · 2020-06-23T14:32:25Z

@magento run all tests

…mftf test for edit and save image details and fix for static failures

…onal implementation for saving image details

…mftf test files

…ed test name

joweecaquicla · 2020-06-28T12:49:06Z

@magento run all tests

…r check failures

joweecaquicla · 2020-06-28T14:00:34Z

@magento run all tests

…ented code

joweecaquicla · 2020-06-28T14:16:43Z

@magento run all tests

…ed test files

joweecaquicla · 2020-06-29T06:59:51Z

@magento run all tests

…ave assets interface

joweecaquicla · 2020-06-29T08:35:19Z

@magento run all tests

…nged used interfaces

joweecaquicla · 2020-06-29T08:59:14Z

@magento run all tests

sivaschenko

Hi @joweecaquicla , looks very good! Please see my review comments

MediaGalleryUi/Controller/Adminhtml/Image/SaveDetails.php

MediaGalleryUi/Test/Mftf/Section/AdminEnhancedMediaGalleryEditDetailsSection.xml

MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryEditSaveImageDetailsTest.xml

MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js

MediaGalleryUi/view/adminhtml/templates/image_edit_details_standalone.phtml

…ed mftf files

joweecaquicla · 2020-06-30T16:32:34Z

@magento run all tests

…ed selector for image description in view image details

joweecaquicla · 2020-06-30T19:09:13Z

@magento run all tests

…ed mftf test files

joweecaquicla · 2020-07-01T17:08:13Z

@magento run Functional Tests B2B

joweecaquicla · 2020-07-01T19:11:44Z

@magento run all tests

…iles for edit save image details test

joweecaquicla · 2020-07-02T03:25:25Z

@magento run Functional Tests B2B

…issue on save details controller and mftf files

joweecaquicla · 2020-07-02T15:00:44Z

@magento run all tests

joweecaquicla · 2020-07-03T04:51:52Z

@magento run Functional Tests B2B

sivaschenko

Thanks for updates @joweecaquicla ! Please see my review comments

MediaGalleryUi/Test/Mftf/ActionGroup/AdminEnhancedMediaGalleryImageDetailsSaveActionGroup.xml

...t/Mftf/ActionGroup/AdminEnhancedMediaGalleryVerifyImageDetailsWithDescriptionActionGroup.xml

MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryEditSaveImageDetailsTest.xml

MediaGalleryUi/Test/Mftf/Section/AdminEnhancedMediaGalleryViewDetailsSection.xml

MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryEditSaveImageDetailsTest.xml

MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryEditSaveImageDetailsTest.xml

…set-attributes

MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js

…t change on mftf files and image-edit js

joweecaquicla · 2020-07-03T16:43:57Z

@magento run all tests

…set-attributes

sivaschenko · 2020-07-06T13:12:31Z

@magento run all tests

sivaschenko · 2020-07-06T13:17:26Z

Great job, @joweecaquicla !
To finalize the PR I have applied the following changes:

Added reload grid action after saving image details to update image title in the media gallery
Added verification of image title on the grid to MFTF tests
Changed AdminEnhancedMediaGalleryImageDetailsSaveActionGroup argument to image for extensibility/flexibility
Passed the image attribute to AdminEnhancedMediaGalleryImageDetailsSaveActionGroup for consistency: same data used to edit details and verify them
Changed AdminEnhancedMediaGalleryVerifyImageDescriptionActionGroup to verify description only and used existing AdminEnhancedMediaGalleryVerifyImageDetailsActionGroup to verify other attributes on image details panel in MFTF tests

sivaschenko · 2020-07-06T20:34:08Z

@magento run Database Compare,Functional Tests CE,Functional Tests EE

ghost · 2020-07-07T10:30:26Z

Hi @joweecaquicla, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

joweecaquicla added 3 commits June 18, 2020 04:04

magento#1440: Create an endpoint for saving asset attributes - added …

e371bd5

…templates for edit image details modal and additional controllers

Merge branch '2.0-develop' into 1440-create-an-endpoint-for-saving-as…

550fed0

…set-attributes

magento#1440: create an endpoint for saving asset attributes - implem…

18e1a50

…ent SaveDetails controller and modifications on script and templates for the edit image form

joweecaquicla requested a review from sivaschenko June 18, 2020 18:29

magento#1440: Create an endpoint for saving asset attributes - modifi…

cd3e6c5

…ed SaveDetails controller and edit details form/slide panel

joweecaquicla changed the title ~~[WIP] #1440: create an endpoint for saving asset attributes~~ #1440: create an endpoint for saving asset attributes Jun 23, 2020

joweecaquicla changed the title ~~#1440: create an endpoint for saving asset attributes~~ [WIP] #1440: create an endpoint for saving asset attributes Jun 23, 2020

joweecaquicla added 4 commits June 26, 2020 02:04

magento#1440: Create an endpoint for saving asset attributes - added …

efb0e48

…mftf test for edit and save image details and fix for static failures

magento#1440: Create an endpoint for saving asset attributes - additi…

f132393

…onal implementation for saving image details

magento#1440: Create an endpoint for saving asset attributes - added …

b7cdfe6

…mftf test files

magento#1440: Create an endpoint for saving asset attributes - modifi…

169e699

…ed test name

joweecaquicla changed the title ~~[WIP] #1440: create an endpoint for saving asset attributes~~ #1440: create an endpoint for saving asset attributes Jun 28, 2020

magento#1440: Create an endpoint for saving asset attributes - fix fo…

d738465

…r check failures

magento#1440: Create an endpoint for saving asset attributes - uncomm…

534a343

…ented code

magento#1440: Create an endpoint for saving asset attributes - modifi…

f3cfbfa

…ed test files

magento#1440: Create an endpoint for saving asset attributes - used s…

e9b8af6

…ave assets interface

magento#1440: Create an endpoint for saving asset attributes - rearra…

2572722

…nged used interfaces

sivaschenko requested changes Jun 29, 2020

View reviewed changes

m2-community-project bot assigned sivaschenko Jun 29, 2020

m2-community-project bot added Progress: review and removed Progress: changes requested labels Jun 30, 2020

magento#1440: Create an endpoint for saving asset attributes - modifi…

06a76de

…ed mftf files

magento#1440: Create an endpoint for saving asset attributes - modifi…

98d0c26

…ed selector for image description in view image details

magento#1440: Create an endpoint for saving asset attributes - modifi…

8f43f2a

…ed mftf test files

magento#1440: Create an endpoint for saving asset attributes - mftf f…

ea60efd

…iles for edit save image details test

magento#1440: Create an endpoint for saving asset attributes - fixed …

8533b39

…issue on save details controller and mftf files

sivaschenko requested changes Jul 3, 2020

View reviewed changes

sivaschenko reviewed Jul 3, 2020

View reviewed changes

MediaGalleryUi/Test/Mftf/Test/AdminMediaGalleryEditSaveImageDetailsTest.xml Outdated Show resolved Hide resolved

sivaschenko reviewed Jul 3, 2020

View reviewed changes

MediaGalleryUi/Test/Mftf/Test/AdminStandaloneMediaGalleryEditSaveImageDetailsTest.xml Outdated Show resolved Hide resolved

Merge branch '2.0-develop' into 1440-create-an-endpoint-for-saving-as…

90ceec4

…set-attributes

sivaschenko reviewed Jul 3, 2020

View reviewed changes

MediaGalleryUi/view/adminhtml/web/js/image/image-edit.js Outdated Show resolved Hide resolved

magento#1440: Create an endpoint for saving asset attributes - reques…

3d96605

…t change on mftf files and image-edit js

sivaschenko added 2 commits July 6, 2020 12:11

Merge branch '2.0-develop' into 1440-create-an-endpoint-for-saving-as…

14daa64

…set-attributes

magento#1506: Added grid reload and adjusted the tests

ed34e2d

sivaschenko merged commit 0ce9445 into magento:2.0-develop Jul 7, 2020

m2-community-project bot removed the Progress: review label Jul 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1440: create an endpoint for saving asset attributes #1506

#1440: create an endpoint for saving asset attributes #1506

joweecaquicla commented Jun 18, 2020 •

edited by sivaschenko

Loading

joweecaquicla commented Jun 23, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 29, 2020

joweecaquicla commented Jun 29, 2020

joweecaquicla commented Jun 29, 2020

sivaschenko left a comment

joweecaquicla commented Jun 30, 2020

joweecaquicla commented Jun 30, 2020

joweecaquicla commented Jul 1, 2020

joweecaquicla commented Jul 1, 2020

joweecaquicla commented Jul 2, 2020

joweecaquicla commented Jul 2, 2020

joweecaquicla commented Jul 3, 2020

sivaschenko left a comment

joweecaquicla commented Jul 3, 2020

sivaschenko commented Jul 6, 2020

sivaschenko commented Jul 6, 2020

sivaschenko commented Jul 6, 2020

ghost commented Jul 7, 2020

#1440: create an endpoint for saving asset attributes #1506

#1440: create an endpoint for saving asset attributes #1506

Conversation

joweecaquicla commented Jun 18, 2020 • edited by sivaschenko Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

joweecaquicla commented Jun 23, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 28, 2020

joweecaquicla commented Jun 29, 2020

joweecaquicla commented Jun 29, 2020

joweecaquicla commented Jun 29, 2020

sivaschenko left a comment

Choose a reason for hiding this comment

joweecaquicla commented Jun 30, 2020

joweecaquicla commented Jun 30, 2020

joweecaquicla commented Jul 1, 2020

joweecaquicla commented Jul 1, 2020

joweecaquicla commented Jul 2, 2020

joweecaquicla commented Jul 2, 2020

joweecaquicla commented Jul 3, 2020

sivaschenko left a comment

Choose a reason for hiding this comment

joweecaquicla commented Jul 3, 2020

sivaschenko commented Jul 6, 2020

sivaschenko commented Jul 6, 2020

sivaschenko commented Jul 6, 2020

ghost commented Jul 7, 2020

joweecaquicla commented Jun 18, 2020 •

edited by sivaschenko

Loading