#1094 : [MFTF] User deletes images using Delete button #1384
Conversation
|
@magento run Functional Tests CE |
|
@magento run Functional Tests CE |
|
@magento run all tests |
There was a problem hiding this comment.
Thanks for the pull request @konarshankar07 ! Please see my review comments
| <group value="media_gallery_ui"/> | ||
| </annotations> | ||
| <before> | ||
| <magentoCLI command="config:set {{MediaGalleryConfigDataEnabled.path}} {{MediaGalleryConfigDataEnabled.value}}" stepKey="enableEnhancedMediaGallery"/> |
There was a problem hiding this comment.
The enhanced media gallery is enable in the suite precondition using the AdminMediaGalleryEnhancedEnableActionGroup.
There is no need to enable disable it in the individual test precondition, as suite preconditions are always executed for the matching tests
| <argument name="imageName" value="{{ImageUpload.file}}"/> | ||
| </actionGroup> | ||
| <actionGroup ref="AdminMediaGalleryImageDeleteActionGroup" stepKey="deleteImage"/> | ||
| <see userInput='You have successfully removed the image "{{ImageUpload.filename}}"' stepKey="verifyDeleteImage"/> |
There was a problem hiding this comment.
I would move that to the AssertAdminMediaGalleryAssetDeleted action group for extensibility
| <features value="MediaGallery"/> | ||
| <useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1094"/> | ||
| <title value="Deleting new image file functionality in Enhanced Media Gallery"/> | ||
| <stories value="Deleting new image file functionality in Enhanced Media Gallery"/> |
There was a problem hiding this comment.
Please add the <testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1054245/scenarios/4756652"/>
|
@magento run all tests |
| <argument name="imageName" type="string" defaultValue=""/> | ||
| </arguments> | ||
|
|
||
| <see userInput='You have successfully removed the image "{{imageName}}"' stepKey="verifyDeleteImage"/> |
There was a problem hiding this comment.
Let's add this verification to existing AssertEnhancedMediaGalleryImageDeletedActionGroup (it would be good to rename that actionGroup to AssertAdminEnhancedMediaGalleryImageDeletedActionGroup)
| <actionGroup ref="AdminOpenMediaGalleryForPageNoEditorActionGroup" stepKey="openMediaGalleryForPage"/> | ||
| </before> | ||
| <after> | ||
| <actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/> |
There was a problem hiding this comment.
the logout is not required as every test is executed in an isolated session
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
| @@ -8,14 +8,14 @@ | |||
|
|
|||
| <actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd"> | |||
| <actionGroup name="AssertEnhancedMediaGalleryImageDeletedActionGroup"> | |||
| <actionGroup name="AssertAdminEnhancedMediaGalleryImageDeletedActionGroup"> | |||
There was a problem hiding this comment.
@konarshankar07 thanks for the updates! Please rename the file according to the action group name change
|
@magento run all tests |
|
Hi @konarshankar07, thank you for your contribution! |
Description (*)
This PR will add MFTF test coverage for the user deleting the image from enhanced media gallery
Fixed Issues (if relevant)