Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1010: Image size is not passed to image-uploader when inserting an image from new media gallery #1021

Conversation

konarshankar07
Copy link
Contributor

@konarshankar07 konarshankar07 commented Mar 22, 2020

Depends on Pull Requests

magento/magento2#27388

Description (*)

This PR will introduce the new column size in media_gallery_asset_grid table which will be used to save the size of the image when media gallery reindexing is perform.

Fixed Issues (if relevant)

  1. Image size is not passed to image-uploader when inserting an image from new media gallery #1010: Image size is not passed to image-uploader when inserting an image from new media gallery

Manual testing scenarios (*)

Please ensure Enhanced Media Gallery is Enabled

  1. Login to Admin panel
  2. Go to Catalog -> Category
  3. Select any category
  4. Expand Content fieldset
  5. Click "Select from Gallery" button next to "Category Image" field
  6. Select any image in the media gallery and click "Add Selected" button

Expected Result

image

Note

Please merge magento repo PR before merging this one

@sivaschenko
Copy link
Member

Depends on magento/magento2#27388

@slavvka
Copy link
Member

slavvka commented Mar 28, 2020

@magento run all tests

1 similar comment
@slavvka
Copy link
Member

slavvka commented Mar 28, 2020

@magento run all tests

@slavvka
Copy link
Member

slavvka commented Mar 29, 2020

magento/magento2#27388 is merged but the static test is failing. please fix it.

@ghost
Copy link

ghost commented Mar 30, 2020

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants