-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1010: Image size is not passed to image-uploader when inserting an image from new media gallery #1021
Merged
sivaschenko
merged 7 commits into
magento:1.1-develop
from
konarshankar07:fixed-image-size-not-passed-task-1010
Mar 30, 2020
Merged
#1010: Image size is not passed to image-uploader when inserting an image from new media gallery #1021
sivaschenko
merged 7 commits into
magento:1.1-develop
from
konarshankar07:fixed-image-size-not-passed-task-1010
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g new media gallery
4 tasks
Depends on magento/magento2#27388 |
@magento run all tests |
1 similar comment
@magento run all tests |
magento/magento2#27388 is merged but the static test is failing. please fix it. |
sivaschenko
approved these changes
Mar 30, 2020
Hi @konarshankar07, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Pull Requests
magento/magento2#27388
Description (*)
This PR will introduce the new column size in
media_gallery_asset_grid
table which will be used to save the size of the image when media gallery reindexing is perform.Fixed Issues (if relevant)
Manual testing scenarios (*)
Please ensure Enhanced Media Gallery is Enabled
Expected Result
Note
Please merge magento repo PR before merging this one