Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert rendition images to the content from media gallery instead of original images #1504

Closed
sivaschenko opened this issue Jun 18, 2020 · 1 comment · Fixed by #1756 or magento/magento2#29677
Closed

Insert rendition images to the content from media gallery instead of original images #1504

sivaschenko opened this issue Jun 18, 2020 · 1 comment · Fixed by #1756 or magento/magento2#29677
Assignees
@jmonteros422
Labels
Backend Frontend/UI Priority: P2 Should be fixed as early as possible Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Milestone
2.1.1

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jun 18, 2020 •
edited
Loading

Story

#1286

Precoditions

  1. Magento2 2.4-develop with ASI 2.1-develop is installed
  2. Enhanced Media Gallery is enabled in Stores Configuration -> Advanced -> System -> Media Gallery fieldset
  3. Rendition width and height are set in Stores Configuration -> Advanced -> System -> Media Gallery Renditions fieldset

Steps to reproduce:

  1. Upload an image that is higher/wider than the configured rendition width/height to the media gallery
  2. Insert the image to the content

Expected result

  • The rendition of the image instead of the original image should be inserted (from .renditions directory)
  • The rendition height/width should be reduced not to exceed configured rendition width and height
  • The rendition of the image should keep the original image aspect ratio
  • Used in information should be updated accordingly and displayed in the Image Details panel of media gallery
@sivaschenko sivaschenko added this to the 2.1.0 milestone Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@lenaorobei lenaorobei removed this from the 2.1.0 milestone Jun 26, 2020
@sivaschenko sivaschenko added this to the 2.2.0 milestone Jul 29, 2020
@lenaorobei lenaorobei removed this from the 2.2.0 milestone Aug 3, 2020
@sivaschenko sivaschenko changed the title Insert rendition images to the content from media gallery instead of original images [2.1-develop] Insert rendition images to the content from media gallery instead of original images Aug 12, 2020
@sivaschenko sivaschenko added Priority: P4 Fixing can be deferred as a logical part of more important work and removed Progress: ready for grooming labels Aug 12, 2020
@sivaschenko sivaschenko added Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround and removed Progress: ready for grooming labels Aug 12, 2020
@jmonteros422 jmonteros422 self-assigned this Aug 13, 2020
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 14, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
195ac85 
…om media gallery instead of original images - Implement interceptors for insert and get paths
@jmonteros422 jmonteros422 mentioned this issue Aug 14, 2020
Merged
@jmonteros422 jmonteros422 linked a pull request Aug 14, 2020 that will close this issue
#1504: [2.1-develop] Insert rendition images to the content from media gallery instead of original images #1756
Merged
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 17, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
f3d80db 
…om media gallery instead of original images - Plugin to intercept on content extract, fix failing test
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 17, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
acfb0f4 
…om media gallery instead of original images - Add dependencies
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 17, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
84af1c4 
…om media gallery instead of original images - static test suppress warning
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 18, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
87666db 
…om media gallery instead of original images - Fix for implementation affecting existing functional tests. Added condition to run only plugin if media content is enabled.
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 18, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
6382229 
…om media gallery instead of original images - Add constructor docs
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 18, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
237bc67 
…om media gallery instead of original images - Add module dependency
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 19, 2020
@jmonteros422
magento/adobe-stock-integration#1504:[Related PR] Insert rendition im…
ff37e3f 
…ages to the content from media gallery instead of original images - Extract logic from controller to a model to enable before plugin interception of parameters
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 19, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
4bcb4d0 
…om media gallery instead of original images - Refactor based on PR suggestions
@jmonteros422 jmonteros422 mentioned this issue Aug 19, 2020
Merged
@sivaschenko sivaschenko added Priority: P2 Should be fixed as early as possible and removed Priority: P4 Fixing can be deferred as a logical part of more important work labels Aug 19, 2020
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 21, 2020
@jmonteros422
magento/adobe-stock-integration#1504: Insert rendition images to the …
29d0707 
…content from media gallery instead of original images - Extracted logic from wysiwyg OnInsert controller to a model
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 21, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
b476914 
…om media gallery instead of original images - Add module dependency - Apply PR suggestions, Added rendition path and html patterns
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 21, 2020
@jmonteros422
magento/adobe-stock-integration#1504:Extract logic from controller to…
e228d76 
… a model to enable before plugin interception of parameters - Test failure fixes. Made store_id parameter optional.
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 21, 2020
@jmonteros422
magento#1504: Insert rendition images to the content from media galle…
a9e147e 
…ry instead of original images - Extracted logic from wysiwyg OnInsert controller to a model - Update store_id parameter order and type
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 21, 2020
@jmonteros422
magento/adobe-stock-integration#1504:Extract logic from controller to…
408cdb7 
… a model to enable before plugin interception of parameters - Fix static test
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 24, 2020
@jmonteros422
magento/adobe-stock-integration#1504: Extracted logic from wysiwyg On…
45849cc 
…Insert controller to a model - Integration test
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 24, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
1635922 
…om media gallery instead of original images - adjustments for regex on wysiwyg with static urls
jmonteros422 added a commit to jmonteros422/magento2-1 that referenced this issue Aug 24, 2020
@jmonteros422
magento/adobe-stock-integration#1504: Extracted logic from wysiwyg On…
10bd41f 
…Insert controller to a model - PR suggestions and Adjustments on Integration test
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 25, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
72ecf87 
…om media gallery instead of original images - Remove plugin and adjust regex patterns to achieve behaviour.
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 25, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
79cc0e4 
…om media gallery instead of original images - Integration test coverage for GetAssetIdsByContentFieldTest for rendition.
@sivaschenko sivaschenko added this to the 2.1.1 milestone Aug 25, 2020
jmonteros422 added a commit to jmonteros422/adobe-stock-integration that referenced this issue Aug 27, 2020
@jmonteros422
magento#1504: [2.1-develop] Insert rendition images to the content fr…
2ec9f68 
…om media gallery instead of original images - Revised integration test
@sivaschenko sivaschenko changed the title [2.1-develop] Insert rendition images to the content from media gallery instead of original images Insert rendition images to the content from media gallery instead of original images Aug 31, 2020
sivaschenko added a commit that referenced this issue Sep 3, 2020
@sivaschenko
Merge pull request #1756 from jmonteros422/1504-Insert-rendition-imag…
85c7cc6 
…es-to-the-content-from-media-gallery-instead-of-original-images

#1504: [2.1-develop] Insert rendition images to the content from media gallery instead of original images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmonteros422 jmonteros422

Labels
Backend Frontend/UI Priority: P2 Should be fixed as early as possible Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.1
3 participants
@sivaschenko @lenaorobei @jmonteros422