Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #1387

Closed
chalov-anton opened this issue May 25, 2020 · 3 comments · Fixed by magento/magento2#29639
Closed

"Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #1387

chalov-anton opened this issue May 25, 2020 · 3 comments · Fixed by magento/magento2#29639
Assignees
@joweecaquicla
Labels
bug Something isn't working Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Milestone
2.1.1

Comments

@chalov-anton
Copy link
Contributor

Preconditions (*)

  1. Install Magento with Adobe Stock Integration
  2. Configured integration in Stores -> Configuration -> Advanced-> System -> Adobe Stock Integration fieldset

Steps to reproduce (*)

  1. Go to Content - Media Gallery
  2. Click Search Adobe Stock
  3. Go to the first page from the grid, and select any image to open its Preview
  4. Click on Default View (bookmarks view)
  5. Click Save View As...,
  6. Click Save all Changes ➡️
  7. Switch to the Default View
  8. Go to the second page in Adobe Stock grid
  9. Switch to the previously created New View

Expected result (*)

No error message in dev console

Actual result (*)

❌ Uncaught TypeError: Cannot read property 'complete' of undefined appears in dev console
uncought_complete_view_2520
@chalov-anton chalov-anton added bug Something isn't working Severity: S4 A minor problem, annoyance, or technical issue with minimal impact labels May 25, 2020
@chalov-anton chalov-anton added this to the 2.0.0 Stabilization milestone May 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 25, 2020

Hi @chalov-anton. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added the Progress: good first issue Good for newcomers label May 26, 2020
@sivaschenko sivaschenko added the Priority: P3 May be fixed according to the position in the backlog label May 26, 2020
@mmezhensky
Copy link

@magento I am working on this

@chalov-anton chalov-anton changed the title "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if svae Previewed image as a new View and open this View on another page "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page Jun 3, 2020
mmezhensky pushed a commit to mmezhensky/adobe-stock-integration that referenced this issue Jun 10, 2020
magento#1387: fix error after switching on saved view
760b686
@mmezhensky mmezhensky mentioned this issue Jun 10, 2020
Closed
@gabrieldagama
Copy link
Contributor

Also related to this issue, when you follow the steps described on the issue, the image that gets displayed on the image preview section is incorrect, currently, it is displaying the image from the previous page, instead of the image from the saved bookmark.

@sivaschenko sivaschenko removed the Progress: good first issue Good for newcomers label Jul 28, 2020
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 18, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
154ebc0 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - created separate function for loading of image data in preview
@joweecaquicla joweecaquicla mentioned this issue Aug 18, 2020
Merged
4 tasks
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Aug 18, 2020
magento#1387: Uncaught TypeError: Cannot read property 'complete' of …
69c6a3e 
…undefined appears in dev console if save Previewed image as a new View and open this View on another page - modification on image-preview.js to fix issue of wrong image showing in image preview section when switching views
@joweecaquicla joweecaquicla mentioned this issue Aug 18, 2020
Closed
@joweecaquicla joweecaquicla linked a pull request Aug 18, 2020 that will close this issue
[WIP] #1387: "Uncaught TypeError: Cannot read property 'complete' of undefined" appears in dev console if save Previewed image as a new View and open this View on another page #1765
Closed
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Aug 18, 2020
magento#1387: Uncaught TypeError: Cannot read property 'complete' of …
fb6e357 
…undefined appears in dev console if save Previewed image as a new View and open this View on another page - added new listener to bookmark provider
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 19, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
61f5cbe 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - suggested modifications
@joweecaquicla joweecaquicla self-assigned this Aug 19, 2020
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 19, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
e2e6b3e 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - requested modifications
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 20, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
d24d07d 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - fix static test and unit test
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 20, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
a2f56ab 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - modified function description
joweecaquicla pushed a commit to joweecaquicla/magento2 that referenced this issue Aug 24, 2020
magento/adobe-stock-integration#1387: Uncaught TypeError: Cannot read…
5ff347c 
… property 'complete' of undefined appears in dev console if save Previewed image as a new View and open this View on another page - fix static test fail
@sivaschenko sivaschenko modified the milestones: 2.1.0, 2.1.1 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
bug Something isn't working Priority: P3 May be fixed according to the position in the backlog Progress: done Severity: S4 A minor problem, annoyance, or technical issue with minimal impact
Projects
None yet
Milestone
2.1.1
6 participants
@sivaschenko @gabrieldagama @lenaorobei @joweecaquicla @chalov-anton @mmezhensky