Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Magento modifies the SKU when creating products and SKU is already used #101

Open
federivo opened this issue Feb 16, 2018 · 3 comments
Open

Magento modifies the SKU when creating products and SKU is already used #101

federivo opened this issue Feb 16, 2018 · 3 comments
Milestone
Phase 1

Comments

@federivo
Copy link
Contributor

Preconditions

  1. Magento 2.x
  2. PHP 5.5 5.6 7.0 7.1
  3. MySql 5.5 5.6

Steps to reproduce

  1. Create a product with SKU "ABC"
  2. Then create another product with the same SKU "ABC"

Expected result

  1. It should alert the user with an error message that the SKU is already in use by another product

Actual result

  1. Magento appends a "-1" to the SKU and saves it.
@federivo
Copy link
Contributor Author

As discussed in Feb 16th import/export meeting, @dmanners will discuss this with a Magento product owner to consider changing actual behavior regarding SKU management.

@federivo federivo mentioned this issue Feb 16, 2018
Open
@federivo
Copy link
Contributor Author

Approved by @piotrekkaminski. Moving forward with this issue.

@federivo federivo assigned federivo and unassigned dmanners Feb 27, 2018
@federivo federivo mentioned this issue Feb 28, 2018
Closed
4 tasks
@dmanners dmanners added this to the Phase 1 milestone Feb 28, 2018
@orlangur
Copy link
Contributor

@federivo @piotrekkaminski what about SKU autogeneration for a new product? As far as I remember current behavior when SKU was left empty and autogenerated one was already in use is to show warning "SKU was changed to ABC-1" or something like that.

I don't see this case covered in linked PR.

magento-engcom-team pushed a commit that referenced this issue Apr 13, 2018
@buskamuza
Merge pull request #101 from maxbucknell/issue/93
5999dfa 
Update `zendframework/zend-code`
magento-engcom-team added a commit that referenced this issue Jul 19, 2018
@magento-engcom-team
ENGCOM-2321: Additional checks for fragments added in category tree #101
f01c5f3 


 - Merge Pull Request magento/graphql-ce#101 from magento/graphql-ce:category-fragment-fix
 - Merged commits:
   1. 284f345
   2. 6c8f256
magento-engcom-team pushed a commit that referenced this issue Jul 19, 2018
ENGCOM-2321: Additional checks for fragments added in category tree #101
b74a600
@dmanners dmanners assigned pogster and unassigned federivo Jul 23, 2018
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Aug 11, 2018
@dmanners
magento-engcom#101: update functional test to expect the newer except…
3d21225 
…ion message
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 11, 2018
@pogster
magento-engcom#101: Re-add SKU generation in case product is duplicat…
f27826e 
…ed. Duplicate needs a SKU to be saved.
@pogster pogster mentioned this issue Aug 11, 2018
Closed
4 tasks
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: Adjust tests to new behaviour.
c39d756
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: Adjust tests to new behaviour.
623b38d
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: Adjust tests to new behaviour.
0da8906
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: Undo error message here.
0e3b985
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: setIsDuplicate(true) to ensure cloned products ge…
77aa5a0 
…t valid SKUs.
pogster added a commit to pogster/import-export-improvements that referenced this issue Aug 18, 2018
@pogster
magento-engcom#101: Undo error message change. Does not fit the test …
cd3f085 
…and the constraint anymore this way. Test needs to be adjusted to result in expected error.
pogster added a commit to pogster/import-export-improvements that referenced this issue Sep 11, 2018
@pogster
magento-engcom#101: Test adjustments to new behaviour. A product's SK…
b117089 
…U won't be changed by beforeSave anymore. Only a duplicated product will receive a changed SKU on its creation.
pogster added a commit to pogster/import-export-improvements that referenced this issue Sep 11, 2018
@pogster
magento-engcom#101: Use unique string for SKU.
60e3320
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Sep 12, 2018
magento-engcom#101: Use unique string for SKU.
ac1c426
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Oct 23, 2018
magento-engcom#101: Change test case to use two different products wi…
5d376fb 
…th the same URL key to prevent 'SKU already exists' error.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@dmanners
magento-engcom#101: update functional test to expect the newer except…
51171db 
…ion message
pogster added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@pogster
magento-engcom#101: Re-add SKU generation in case product is duplicat…
d353d01 
…ed. Duplicate needs a SKU to be saved.
pogster added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@pogster
magento-engcom#101: Adjust tests to new behaviour.
ec142af
pogster added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@pogster
magento-engcom#101: setIsDuplicate(true) to ensure cloned products ge…
3d6c474 
…t valid SKUs.
pogster added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@pogster
magento-engcom#101: Undo error message change. Does not fit the test …
1326f9b 
…and the constraint anymore this way. Test needs to be adjusted to result in expected error.
pogster added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@pogster
magento-engcom#101: Test adjustments to new behaviour. A product's SK…
3d05ec7 
…U won't be changed by beforeSave anymore. Only a duplicated product will receive a changed SKU on its creation.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
magento-engcom#101: Change test case to use two different products wi…
2368e8f 
…th the same URL key to prevent 'SKU already exists' error.
dmanners added a commit to pogster/import-export-improvements that referenced this issue Oct 24, 2018
@dmanners
magento-engcom#101: file clean-up
f263548 
Clean up the header of the class to fit with the static-tests.
pogster pushed a commit to pogster/import-export-improvements that referenced this issue Nov 7, 2018
magento-engcom#101: Merge origin/2.3-develop.
f3ffd31
@dmanners dmanners mentioned this issue May 6, 2019
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Phase 1
Development

No branches or pull requests
4 participants
@federivo @orlangur @dmanners @pogster