Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: -d directory contains magefiles directory does not work #447

Closed
turutcrane opened this issue Nov 4, 2022 · 3 comments · Fixed by #448
Closed

Bug: -d directory contains magefiles directory does not work #447

turutcrane opened this issue Nov 4, 2022 · 3 comments · Fixed by #448
Labels
🐜 bug

Comments

@turutcrane
Copy link
Contributor

Bug Description
-d directory contains magefiles directory does not work

What did you do?
$ mage -d DIR target

DIR contains magefiles directory.

What did you expect to happen?
Execute target in DIR/magefiles.

What actually happened?
mage stop with "No .go files marked with the mage build tag in this directory."

Environment

  • Mage Version:
    Mage Build Tool v1.14.0
    Build Date: 2022-11-04T21:23:44+09:00
    Commit: 300bbc8
    built with: go1.19.2

  • OS: windows msys2 / linux (WSL2)

Additional context
None
turutcrane added a commit to turutcrane/mage that referenced this issue Nov 4, 2022
@turutcrane
-d dir contains magefiles stop with "No .go files marked with the mag…
f479f7e 
…e build tag..." (magefile#447)
@turutcrane turutcrane mentioned this issue Nov 4, 2022
Merged
@natefinch
Copy link
Member

Ahh interesting point, yeah, -d should be smart enough to figure out if you have a magefiles directory or not, and use that if it's there.

@turutcrane
Copy link
Contributor Author

I tryed to fix it by PR #448. Please review it.

perrito666 pushed a commit to turutcrane/mage that referenced this issue Feb 23, 2023
@turutcrane @perrito666
-d dir contains magefiles stop with "No .go files marked with the mag…
8d633fa 
…e build tag..." (magefile#447)
perrito666 pushed a commit that referenced this issue Feb 23, 2023
@turutcrane
-d dir contains magefiles stop with "No .go files marked with the mag…
1b8774a 
…e build tag..." (#447) (#448)
@perrito666
Copy link
Contributor

Thank you @turutcrane for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐜 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

-d dir contains magefiles stop with "No .go files marked with the mag…" #447 turutcrane/mage
3 participants
@perrito666 @natefinch @turutcrane