-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local cache and actions/cache support #277
Add local cache and actions/cache support #277
Conversation
@crazy-max could you please to have a look at this fix. Thanks in advance. |
Sorry for the delay, can you rebase please? |
3fccf0f
to
4524a99
Compare
Yes, sure. Did it. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thanks for your contrib. See my comments.
.gitignore
Outdated
|
||
# IDE directories | ||
.vscode/ | ||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, please remove this change. You can add your own exclusions in a global .gitignore
on your host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, it can be covered by options in global .gitignore
, but some projects can store IDE's specific folders inside the repository. But in this case, I will remove it.
52002ef
to
efeacec
Compare
Co-authored-by: CrazyMax <[email protected]> Signed-off-by: Dmitry Volodin <[email protected]>
efeacec
to
b8b6e3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@crazy-max thanks for merging PR. Could you please to release new version. |
Fixes #264