Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local cache and actions/cache support #277

Merged
merged 1 commit into from
May 9, 2023

Conversation

dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Apr 1, 2023

Fixes #264

@dmvolod dmvolod requested a review from crazy-max as a code owner April 1, 2023 13:49
@dmvolod
Copy link
Contributor Author

dmvolod commented Apr 3, 2023

@crazy-max could you please to have a look at this fix. Thanks in advance.

@crazy-max
Copy link
Member

Sorry for the delay, can you rebase please?

@dmvolod dmvolod force-pushed the feature/cache-support-issue-264 branch from 3fccf0f to 4524a99 Compare May 9, 2023 07:00
@dmvolod
Copy link
Contributor Author

dmvolod commented May 9, 2023

Sorry for the delay, can you rebase please?

Yes, sure. Did it. Please review

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for your contrib. See my comments.

.gitignore Outdated
Comment on lines 54 to 57

# IDE directories
.vscode/
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary, please remove this change. You can add your own exclusions in a global .gitignore on your host.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it can be covered by options in global .gitignore, but some projects can store IDE's specific folders inside the repository. But in this case, I will remove it.

src/installer.ts Outdated Show resolved Hide resolved
src/installer.ts Outdated Show resolved Hide resolved
@dmvolod dmvolod force-pushed the feature/cache-support-issue-264 branch 2 times, most recently from 52002ef to efeacec Compare May 9, 2023 14:17
Co-authored-by: CrazyMax <[email protected]>

Signed-off-by: Dmitry Volodin <[email protected]>
@dmvolod dmvolod force-pushed the feature/cache-support-issue-264 branch from efeacec to b8b6e3d Compare May 9, 2023 14:18
@dmvolod dmvolod requested a review from crazy-max May 9, 2023 14:18
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max merged commit 3fb3a0c into magefile:master May 9, 2023
@dmvolod
Copy link
Contributor Author

dmvolod commented May 10, 2023

@crazy-max thanks for merging PR. Could you please to release new version.
Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mage Github action appears to download mage on every run without caching
2 participants