The decoder fails parsing zero-length boxes #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug where the decoder halts after encountering a zero-length box.
E.g. calling
decode(function(box))
in the handler for thebox
event, never calls the provided callback if the box has acontentLen
of zero. Theignore
method is also affected by this.This pull-request contains a failing test.
A quick solution for only fixing
decode
would be to add a zero-length check to theDecoder.prototype._buffer
method.I think similar checks could also be added to
Decoder.prototype._stream
andDecoder.prototype.ignore
methods.