Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled copying of symlinked dirs; updated tests #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisekelley
Copy link

2 lines of code called directly lstat, instead of using the local stat
function, which tests if dereference == true

2 lines of code called directly lstat, instead of using the local stat
function, which tests if dereference == true
@chrisekelley
Copy link
Author

There is still a failed test - "mirror regular fs to custom fs" in test/index.js line 135:

    operator: error
    expected: |-
      undefined
    actual: |-
      { [Error: EISDIR: illegal operation on a directory, read] errno: -21, code: 'EISDIR', syscall: 'read' }
    at: EventEmitter.<anonymous> (/Users/ckelley/source/mirror-folder/test/index.js:135:9)
    stack: |-
      Error: EISDIR: illegal operation on a directory, read

I wonder if it is not catching the "dereference:true" property?

    var progress = mirror(fixtures, {fs: archive, name: '/', dereference: true}, function (err) {

@chrisekelley
Copy link
Author

If you accept this PR, I'd recommend updating the README to be very clear that if you have symlinks, you will get an error unless you set dereference:true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant