*Bug* Incorrect Typecasting of RequestDurationInDays in Eidsca CR04 Test Leading to Wrong Comparison Results

[HCRitter]

Description:
When testing the Eidsca CR04 in a tenant, the test returns a value of 5 days for RequestDurationInDays, which is clearly below the 30-day threshold. However, the test incorrectly reports that the duration is not 30 days or less. The issue is caused by an unnecessary and incorrect typecasting to a string, leading to a faulty comparison.

Failing code:

$result = Invoke-MtGraphRequest -RelativeUri "policies/adminConsentRequestPolicy" -ApiVersion beta

[string]$tenantValue = $result.requestDurationInDays
$testResult = $tenantValue -le '30'
$tenantValueNotSet = $null -eq $tenantValue -and '30' -notlike '*$null*'

---

Steps to Reproduce:

1. Execute the following code snippet:

  [string]$Tenantvalue = 5
  $TestResult = $TenantValue -le '30'
  $tenantValueNotSet = $null -eq $tenantValue -and '30' -notlike '*$null*'

2. Observe that the comparison is not behaving as expected.
3. Check the property type using:

(Get-MgPolicyAdminConsentRequestPolicy).RequestDurationInDays.gettype()

The property is already an integer, which means that the cast to a string is unnecessary.

---

Expected Behavior

• The test should correctly compare the integer value without converting it to a string.
• A tenant value of 5 should be recognized as less than or equal to 30.

---

Actual Behavior

• The string conversion leads to an incorrect comparison, resulting in the test always failing the condition.

---

Suggested Fix

• Remove the explicit string cast for RequestDurationInDays to ensure the comparison uses the native integer type.

---

Source

Test-MtEidscaCR04