Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New versions #601

Merged
merged 6 commits into from
Apr 17, 2024
Merged

New versions #601

merged 6 commits into from
Apr 17, 2024

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Apr 17, 2024

  • The branch is named new-versions, such that the full CI will run.
  • Changelogs have only been modified under the Unreleased header.
  • Version numbers are bumped in the following order:
  • Local tests have been run (see helper-scripts/test-local.fish):
    • macOS 10.14.6 32bit
    • iOS 9.3.6, 1st generation iPad Mini

Post merge:

  • Crates are published using cargo publish (or maybe cargo release?)
  • A tag is created on the merge commit for each new version.
  • icrate v0.1.1 is published, deprecating the crate and linking to the new alternatives.

@madsmtm madsmtm added this to the Polish icrate milestone Apr 17, 2024
Copy link
Collaborator

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at every file it seems correct to me. Out of curiosity, why do the framework-crates don't use objc2 or block2 as a workspace dependency? There's probably a good reason but figured I'd ask.

@madsmtm
Copy link
Owner Author

madsmtm commented Apr 17, 2024

why do the framework-crates don't use objc2 or block2 as a workspace dependency? There's probably a good reason but figured I'd ask.

Because I found that since I autogenerate the Cargo.tomls, it wasn't really a maintenance restriction, and then I might as well maintain a MSRV of 1.60 for at least a little while yet. Will do it as part of #577.

@madsmtm madsmtm merged commit fcb3e1d into master Apr 17, 2024
28 checks passed
@madsmtm madsmtm deleted the new-versions branch April 17, 2024 19:57
@madsmtm
Copy link
Owner Author

madsmtm commented Apr 17, 2024

Update: I'm hitting crates.io's rate-limits for publishing new crates, it's gonna take me a while to get all of these out. I've sent an email to the crates.io team and requested an increase, so that it doesn't happen again.

Additionally, I ended up publishing icrate v0.1.2, as both v0.1.0 and v0.1.1 stops compiling with the newer objc2 v0.5.1, since they used glob imports, and I added the NSObjectProtocol::hash method. I considered yanking objc2, but decided to go this route instead since I caught and fixed the problem within ~2.5 hours, and it's only if someone happened to run cargo update in that time-frame that their build would be broken (and the fix for users would be cargo update no matter which path I took to fix it).

Will add you (@simlay) as co-owner once everything is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants