Rework cargo features #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
rework-cargo-features
branch
from
e4ba27c to
bc56b93
Compare
madsmtm
force-pushed
the
rework-cargo-features
branch
7 times, most recently
from
c3461d4 to
c431b8e
Compare
madsmtm
force-pushed
the
rework-cargo-features
branch
4 times, most recently
from
3840faa to
3d26587
Compare
madsmtm
force-pushed
the
rework-cargo-features
branch
from
3d26587 to
0ee1323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
icrateCargo features to be per file instead of per class. This means that all items are now properly feature-gated, which should improve compile time!Amazingly, Cargo allows features to depend on each other, which actually works out perfectly for our use-case, and allows us to do things in a way that should be fairly easy to understand; whenever a file A uses some type from file B, the Cargo feature for file A then requires the Cargo feature for file B. This means that everything defined in the file is now guaranteed to be available, and you only have to worry about the feature flags for things that you import.EDIT: I've decided to go with another option for now; no features depend on each other. This is a lot more verbose in the user's Cargo.toml, but the compile-time benefits are immense!
Part of #537.