Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the traits in it to
objc2::encode
, and make itno_std
and target/platform-agnostic. I also fixed bitfields along the way.Now,
objc2_encode
just contains the parsing/representation of encodings (which may be usable elsewhere, e.g. in an Objective-C compiler or something).This is done because I've found that keeping the
Encode
/RefEncode
/EncodeConvert
traits in a separate crate than the rest ofobjc2
is just too much of a hassle, and a blocker for #277.Downside is that
block2
now depends onobjc2
instead of justobjc2-encode
, which makes the compilation graph slightly worse, but eh, on the other handobjc2-encode
now has no dependencies.