Improve safety in foundation arrays wrt. ownership #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
foundation-id-usage
branch
3 times, most recently
from
663245c to
f1f12ec
Compare
madsmtm
force-pushed
the
foundation-id-usage
branch
from
f1f12ec to
1bffc9f
Compare
madsmtm
changed the title
These types really _cannot_ be used without that bound!
Can be useful in generic contexts
madsmtm
force-pushed
the
foundation-id-usage
branch
from
7eec09b to
a270d44
Compare
madsmtm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #67.
I took a look at how we do arrays again, and while a bit confusing with the double-ownership (e.g.
Id<Array<T, O1>, O2>), I'm now fairly confident that it is sound.