Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NSValue and add NSNumber #226

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Improve NSValue and add NSNumber #226

merged 2 commits into from
Jul 31, 2022

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jul 29, 2022

  • Remove generics from NSValue
  • Add safe accessor functions to NSValue
  • Add NSNumber

@madsmtm madsmtm added enhancement New feature or request A-framework Affects the framework crates and the translator for them labels Jul 29, 2022
@madsmtm madsmtm force-pushed the better-nsvalue branch 6 times, most recently from 70a32c2 to 4751171 Compare July 29, 2022 14:36
Comment on lines +28 to +30
pub(super) const POINT: &str = "CGPoint";
pub(super) const SIZE: &str = "CGSize";
pub(super) const RECT: &str = "CGRect";
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unsure about this, but it seems like it is what NSValue::encoding returns when created from one of these

@madsmtm madsmtm merged commit 9fa9315 into master Jul 31, 2022
@madsmtm madsmtm deleted the better-nsvalue branch July 31, 2022 10:18
This was referenced Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-framework Affects the framework crates and the translator for them enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant