Make Class no longer implement Message directly
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
class-not-message
branch
from
87bb19f to
ce8393d
Compare
madsmtm
force-pushed
the
msg-send-receiver-soundness
branch
3 times, most recently
from
7a94811 to
2beef61
Compare
This is done so that: - `Id<T, O>` is correct for all `T: Message` (currently `Id<Class, _>` is possible). - `ClassBuilder::add_method` doesn't accept functions that take `&Class` as the receiver.
madsmtm
force-pushed
the
class-not-message
branch
from
ce8393d to
9bd6cc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #150.This is changed so that:
Id<T, O>is correct for allT: Message(currentlyId<Class, O>is possible).ClassBuilder::add_methoddoesn't accept functions that take&Classas the receiver.Closes #66 as this is IMO the better alternative (causes less churn and confusion about a lot of different traits).