Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minizip: use single ZREAD64 call in unz64local_getShort/Long/Long64 #826

Closed

Conversation

eugenegff
Copy link
Contributor

minizip: use single ZREAD64 call in unz64local_getShort/Long/Long64 implementation, rather than read it byte by byte.

Code is still compatible with big endian architectures. At the same time both Clang and GCC are able to reinterpret local uchar c[N] array as appropriately sized little endian unsigned number on x64 arch, instead of performing shifting and or-ing calculations.

@gvollant
Copy link
Contributor

@madler @Neustradamus this PR is a good idea and fine, can be merged

@madler madler changed the base branch from master to develop July 30, 2023 06:37
@madler
Copy link
Owner

madler commented Jul 30, 2023

@eugenegff Can you fix this commit to work on the develop branch?

@eugenegff
Copy link
Contributor Author

@eugenegff Can you fix this commit to work on the develop branch?

Wow, real Mark Adler wrote to me! :)
Done.

@Neustradamus
Copy link

@madler
Copy link
Owner

madler commented Aug 3, 2023

@eugenegff Thanks, but it still says there are conflicts.

…mplementation, rather than read it byte by byte
@eugenegff eugenegff force-pushed the single_zread64_for_getLong branch from f14881e to 535faf2 Compare August 3, 2023 17:54
@eugenegff
Copy link
Contributor Author

eugenegff commented Aug 3, 2023

@eugenegff Thanks, but it still says there are conflicts.

@madler I don't see any conflicts, only macOS GCC build agent says that

Could not find compiler set in environment variable CC:

Anyway, I rebased commit directly above the top of the madler:develop branch rather than merge with it. Working copy was not changed, only commits tree is simplified. macOS GCC build agent still complaining that it

Could not find compiler set in environment variable CC:

@madler
Copy link
Owner

madler commented Aug 3, 2023

@eugenegff Thanks! That worked. (No, not from the build agent. It said right here on this page that there were conflicts, where it now says "This branch has no conflicts.")

Applied.

@madler madler closed this Aug 3, 2023
@eugenegff eugenegff deleted the single_zread64_for_getLong branch August 3, 2023 18:35
@eugenegff eugenegff restored the single_zread64_for_getLong branch August 3, 2023 18:35
@Neustradamus
Copy link

Merged commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants