Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $CC if variable is set #662

Closed
wants to merge 1 commit into from
Closed

Use $CC if variable is set #662

wants to merge 1 commit into from

Conversation

RobinGeffroy
Copy link

Fixes commit e9a52aa
cc variable is set if CC is not set, and ignored otherwise.

I was unable to build zlib on Linux because $CC was set
To reproduce :

CC=gcc ./configure --shared
make

Results :

make
/usr/bin/ld: deflate.lo: relocation R_X86_64_PC32 against symbol `_length_code' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: bad value
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:282: libz.so.1.2.12] Error 1

Fixes commit e9a52aa
cc variable is set if CC is not set, and ignored otherwise.
@Mr-Clam
Copy link

Mr-Clam commented Jun 7, 2022

More details in #646, which was closed without a fix.

@RobinGeffroy
Copy link
Author

@Mr-Clam thanks for the link.
Since this is a regression caused by a commit for v1.2.12, I assumed it was unintentional.

@Mr-Clam
Copy link

Mr-Clam commented Jun 7, 2022

Right. And to correct me comment, there is this commit in the develop branch: 05796d3

@RobinGeffroy
Copy link
Author

Fixed in develop branch, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants