cmake build enhancements, mostly for windows, with some documentation #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
commented
Nov 23, 2017
|
|
||
| if(WIN32) | ||
| # Creates zlib1.dll when building shared library version | ||
| set_target_properties(zlib PROPERTIES SUFFIX "1.dll") |
There was a problem hiding this comment.
#273 recommends a different approach - tagging so we don't lose track of it.
options used in the build process. Add an option BUILD_STATIC_AND_SHARED to the cmake build, default ON to emulate past behavior, which when set to OFF allows one to generate just one library from the build process. This is useful on Windows where static and shared may want different compilation flags to be optimal. Add cmake install directives to get the PDB files for MSVC Debug / RelWithDebInfo config builds placed into the install bin directory. Added cmake build documentation for zlib as well as a batch file that can generate many different windows build configurations to be used as an example.
jeking3
force-pushed
the
msvc-cmake-enhancements
branch
from
72f82ba to
c4a2cd0
Compare
|
As a Linux user (i.e. I cannot really review the Windows part), this PR makes sense to me. Somehow it seems like @madler is not maintaining libz anymore, right? What should be done in such a case? Could @madler add another maintainer to this project (if somebody accepts to do it)? Or is there an active fork somewhere? |
This was referenced Dec 13, 2020
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake option declarations for the SKIP_INSTALL_* and other
options used in the build process.
Add an option BUILD_STATIC_AND_SHARED to the cmake build, default
ON to emulate past behavior, which when set to OFF allows one to
generate just one library from the build process. This is useful
on Windows where static and shared may want different compilation
flags to be optimal.
Add cmake install directives to get the PDB files for MSVC
Debug / RelWithDebInfo config builds placed into the
install bin directory.
Added cmake build documentation for zlib as well as a batch
file that can generate many different windows build configurations
to be used as an example.
This pull request would be even better with continuous integration.
I am going to work on a pull request for that next. Thanks!