Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vc15 build files to contrib/vstudio. #270

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sav0966
Copy link

@Sav0966 Sav0966 commented Jul 2, 2017

I've added vc15 build fileles and tested the result with Visual Studio 2017 professional (Windows 10 and SDK 10.0.15063.0). Also I've added brebuild steps to zlibstat project (Release x64/Win32 configurations) to compile assembler files there.

Sav0966 added 2 commits July 2, 2017 19:15
Update path to bld_ml64.bat in x64/DEBUG and remove Safe Exception
Handling in Win32/DEBUG
@tbeu
Copy link
Contributor

tbeu commented Aug 15, 2017

See also #243.

@Sav0966
Copy link
Author

Sav0966 commented Aug 15, 2017 via email

@jeking3
Copy link

jeking3 commented Nov 20, 2017

The project already has cmake support. Why would one check in static MSVC project files when you can have cmake generate them for you, for whichever version of Visual Studio that you have?

@tbeu
Copy link
Contributor

tbeu commented Nov 20, 2017

Why would one check in static MSVC project files when you can have cmake generate them for you, for whichever version of Visual Studio that you have?

To have all the nice features of static VS project files, e.g., multi-configuration, search, manual adaption of settings etc.

@jeking3
Copy link

jeking3 commented Nov 20, 2017

You can keep your search files around and regenerate project files from cmake.
CMake creates multi-configuration projects.

@lukasf
Copy link

lukasf commented Jan 17, 2019

It's good that you can also build configurations with CMake. But a VC project file can be built directly with MSBuild without even opening VS, no need to manually create configurations first, it can be opened in VS with all files nicely organized, it can be debugged more easily.

So why can't we just merge this? It won't prevent anyone from using CMake.

@jeking3
Copy link

jeking3 commented Jan 17, 2019

Author of this repo has been /afk for 2 years, so not sure anything's going to happen.

@lukasf
Copy link

lukasf commented Jan 18, 2019

Oh I see, that's too bad...

@praiskup
Copy link

It's not correct, see the development in devel branch. But AFAIK contrib/ directory is not supported, see the README.

@jeking3
Copy link

jeking3 commented Jan 18, 2019

Well then @madler has the GitHub site configured incorrectly, as all the pull requests are targeting master and not develop.

@lukasf
Copy link

lukasf commented Jan 18, 2019

@praiskup We don't want support, the files there work correctly. We'd just like to add one more build file for latest VS version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants