Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sln/vcxproj file format. (CRLF) #242

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kiyolee
Copy link

@kiyolee kiyolee commented Mar 18, 2017

Fixed some sln/vcxproj files to use what Visual Studio would generate. (using CRLF)
Added UTF-8-BOM and the leading blank line to DotZLib.sln.

@kiyolee kiyolee closed this Aug 28, 2023
@kiyolee kiyolee deleted the fix-file-format branch August 28, 2023 12:20
@Neustradamus
Copy link

@kiyolee: Why have you closed your PR?

cc: @madler!

@kiyolee
Copy link
Author

kiyolee commented Aug 31, 2023

The PR has been 5+ years old. Just thought it is not needed.

@Neustradamus
Copy link

@kiyolee: No, there was a problem, PRs were not looked by the author, now it is in progress.
@madler has started to look it after several requests, currently there are a lot yet.

@kiyolee kiyolee restored the fix-file-format branch September 1, 2023 05:17
@kiyolee kiyolee reopened this Sep 1, 2023
@kiyolee kiyolee changed the base branch from master to develop September 1, 2023 05:24
@kiyolee
Copy link
Author

kiyolee commented Sep 1, 2023

Restored the branch, rebase to develop.
Reopened the PR. See if that's ok.

@Neustradamus
Copy link

@kiyolee: Thanks, now I hope that @madler can look and reply here ^^
If you have other PRs too, please look too...

@nmoinvaz
Copy link
Contributor

nmoinvaz commented Sep 1, 2023

@madler I recommend just delete all the vstudio projects and force people to generate them with cmake. I don't see JetBrains projects.. or projects for any other IDE. These files need constant maintenance and are a support burden.

@kiyolee
Copy link
Author

kiyolee commented Sep 1, 2023

You may well just leave the burden to me: https://github.com/kiyolee/zlib-win-build.
I have been maintaining more extensive VS support in my repo for years.

@Vollstrecker Vollstrecker mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants