Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize cmake file and do cmake-format #1004

Closed
wants to merge 4 commits into from
Closed

Modernize cmake file and do cmake-format #1004

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4427b9
Modernize cmake file and do cmake-format
ClausKlein Aug 22, 2024
54c0498
Try to fix gcc tests on macOS CI workflows
ClausKlein Aug 22, 2024
758d09a
Merge branch 'develop' into feature/modernize-cmake
ClausKlein Sep 24, 2024
279e82a
Add CPACK_GENERATOR setup
ClausKlein Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,3 +235,6 @@ if(NOT SKIP_INSTALL_FILES)
install(FILES zlib.3 DESTINATION "${CMAKE_INSTALL_MANDIR}/man3")
install(FILES ${ZLIB_PC} DESTINATION "${ZLIB_INSTALL_PKGCONFIG_DIR}")
endif()

set(CPACK_GENERATOR TGZ)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CPack generator shouldn't be set here. Let the consumer decide which method they want to used to package.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That set only the default and may be changed with cpack -g ...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

include(CPack)