Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes for PNP with Sanity and unit test #8

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

abimishr
Copy link
Collaborator

No description provided.

return self

pnp_spec = {
'template_name': {'required': True, 'type': 'str'},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'template_name': {'type': 'str', 'required': True},

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done

def get_want(self, config):
"""Get all the image, site and pnp related information from playbook that is needed to be created in DNAC"""

want = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write self.want = { }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done as well

@abimishr abimishr closed this Sep 22, 2023
@abimishr abimishr reopened this Sep 22, 2023
@abimishr abimishr closed this Sep 22, 2023
@abimishr abimishr reopened this Sep 22, 2023
@madhansansel madhansansel reopened this Sep 22, 2023
@madhansansel madhansansel merged commit ee9b083 into madhansansel:main Sep 22, 2023
15 checks passed
madhansansel pushed a commit that referenced this pull request Jan 31, 2024
Merge pull request #112 from rukapse/dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants