Resolved the previous PR comments and have added single addition in P… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhansansel
reviewed
Nov 7, 2023
plugins/modules/pnp_intent.py
Outdated
| template_name = self.want.get("template_name") | ||
| if template_name: | ||
| if template_list and isinstance(template_list, list): | ||
|
|
plugins/modules/pnp_intent.py
Outdated
| (site_exists, site_id) = self.site_exists() | ||
| if not isinstance(self.want.get("site_name"), str) and \ | ||
| not self.want.get('pnp_params').get('deviceInfo').get('add_device_method'): | ||
| self.module.fail_json(msg="Name of the site must be a string", response=[]) |
There was a problem hiding this comment.
can we set the self (status, msg) and return self from here. Check the get_have().check_return_status in main. Can we followup in all the cases?
plugins/modules/pnp_intent.py
Outdated
| self.module.fail_json(msg="Project Not Found or Project is Empty", response=[]) | ||
|
|
||
| else: | ||
| self.module.fail_json(msg="Project Not Found \ |
There was a problem hiding this comment.
set and return instead of failing Json. this should be taken care in check_return_status..
plugins/modules/pnp_intent.py
Outdated
| else: | ||
| self.module.fail_json(msg="Site not found", response=[]) | ||
| if not self.want.get('pnp_params').get('deviceInfo').get('add_device_method'): | ||
| self.module.fail_json(msg="Site not found", response=[]) |
There was a problem hiding this comment.
set and return instead of failing Json. this should be taken care in check_return_status..
plugins/modules/pnp_intent.py
Outdated
| self.want["vlanId"] = config.get('vlanId') | ||
| self.want["ipInterfaceName"] = config.get('ipInterfaceName') | ||
| if self.want["pnp_type"] != "Default": | ||
|
|
plugins/modules/pnp_intent.py
Outdated
| self.module.fail_json(msg="Device needs to be added before claiming", response=[]) | ||
| else: | ||
| if not self.want["site_name"]: | ||
|
|
plugins/modules/pnp_intent.py
Outdated
| self.result['diff'] = self.validated_config | ||
| self.result['changed'] = True | ||
| else: | ||
| self.module.fail_json(msg="Device Addition Failed", response=[]) |
There was a problem hiding this comment.
set and return instead of failing Json. this should be taken care in check_return_status.... We can check the failure condition and return from there itself.
plugins/modules/pnp_intent.py
Outdated
| self.result['diff'] = self.validated_config | ||
| self.result['changed'] = True | ||
| else: | ||
| self.module.fail_json(msg="Device Claim Failed", response=[]) |
There was a problem hiding this comment.
set and return instead of failing Json. this should be taken care in check_return_status..
| Initialize an instance of class . | ||
|
|
||
| Parameters: | ||
| module (ModuleType): The Python module associated with this instance. |
There was a problem hiding this comment.
we can leave 2 spaces then start with -
Parameters:
- module (ModuleType): The Python module associated with this instance.
Attributes:
- module (ModuleType): The provided module.
- test_data (dict): The loaded playbook data from the module.
- playbook_config (dict): The playbook configuration.
- playbook_config_missing_param (dict): The playbook configuration with missing parameters.
| Mocks the initialization and execution of the Cisco DNA Center SDK to isolate testing from actual SDK operations. | ||
|
|
||
| Mocked attributes: | ||
| - mock_dnac_init: Mocks the initialization of the DNACSDK class. |
|
New changes are added |
madhansansel
approved these changes
Nov 9, 2023
madhansansel
pushed a commit
that referenced
this pull request
May 3, 2024
latest changes 04/15/2024
sonalideepthi777
pushed a commit
to sonalideepthi777/madhan-dnacenter-ansible
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description: Adding single device in PnP
Fix: Single addition is possible with add_device_method in the playbook
Design consideration: Device is not added
Testing Information: Tested with multiple scenarios and have also added idempotency