Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplication issue in LAN automation workflow manager - CSCwn27648 #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maaliaj
Copy link

@maaliaj maaliaj commented Dec 17, 2024

Description

Please include a summary of the changes and the related issue. Also, include relevant motivation and context.

Type of Change

  • [X ] Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • [X ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [x ] Any dependent changes have been merged and published in downstream modules
  • [ x] All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • [ x] Tasks are idempotent (can be run multiple times without changing state)
  • [ x] Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • [ x] Playbooks are modular and reusable
  • [ x] Handlers are used for actions that need to run on change

Documentation

  • [x ] All options and parameters are documented clearly.
  • [ x] Examples are provided and tested.
  • [ x] Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant