Site enhancement module #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,7 +410,7 @@ | |||
| """ | |||
|
|
|||
| floor_plan = { | |||
| '101101': 'Cubes And Walled Offices', | |||
| '107107': 'Cubes And Walled Offices', | |||
There was a problem hiding this comment.
Why do we need to change this?
| - If the response is empty, a warning is logged. | ||
| - Any exceptions during the API call are caught, logged as errors, and the function returns None. | ||
| """ | ||
|
|
There was a problem hiding this comment.
self.log("Fetching site details for site hierarchy: '{0}'".format(site_name_hierarchy), "INFO")
| ) | ||
|
|
||
| if not response: | ||
| self.log("The response from 'get_sites' is empty.", "WARNING") |
There was a problem hiding this comment.
Always print with site_name.. Otherwise how do we know it?
self.log("Empty response received for site: {0}".format(site_name_hierarchy), "WARNING")
| self.log("The response from 'get_sites' is empty.", "WARNING") | ||
| return None | ||
|
|
||
| self.log("Received API response from 'get_sites': {0}".format(str(response)), "DEBUG") |
There was a problem hiding this comment.
self.log("Received API response for site '{0}' from 'get_sites': {1}".format(site_name_hierarchy, response), "DEBUG")
| return response | ||
|
|
||
| except Exception as e: | ||
| self.log("An error occurred in 'get_sites':{0}".format(e), "ERROR") |
|
|
||
| return (site_exists, current_site) | ||
| try: | ||
| bulk_operation = self.config[0].get('site', {}).get('bulk_operation', False) |
There was a problem hiding this comment.
Do we support bulk operation for the CatC version below 2.3.5.3?
There was a problem hiding this comment.
No, Added else condition now above try block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Site module to support for replacement of membership APIs, and implement bulk site creation and upload floor map, update and delete site APIs for improved functionality with version-based routing.
Type of Change
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers