Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered the device_config details before removing the devices from the fabric #444

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

MUTHU-RAKESH-27
Copy link
Collaborator

@MUTHU-RAKESH-27 MUTHU-RAKESH-27 commented Oct 24, 2024

Description

Ordered the device_config details before removing the devices from the fabric
Because the first node that should be added to the fabric is a CONTROL_PLANE_NODE and the last should be deleted from the fabric is also the CONTROL_PLANE_NODE.
If user passes series of devices that to be removed from the fabric, we will order it in such a way that the CONTROL_PLANE_NODE should be removed at last from the fabric.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

@madhansansel madhansansel merged commit e5b3214 into madhansansel:main Oct 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants