User and role bug fixed #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for password_regex in password_regexs: | ||
| if password_regex.match(password): | ||
| is_valid_password = True | ||
| is_valid_password_check1 = True |
There was a problem hiding this comment.
self.log("Password meets character type and length requirements.", "INFO")
There was a problem hiding this comment.
Updated the code accordingly.
| - The password must include characters from at least three of the following classes: | ||
| lowercase letters, uppercase letters, digits, and special characters. | ||
| """ | ||
| is_valid_password = False | ||
| is_valid_password_check1 = False |
There was a problem hiding this comment.
meets_character_requirements = False
There was a problem hiding this comment.
Updated the code accordingly.
| - The password must include characters from at least three of the following classes: | ||
| lowercase letters, uppercase letters, digits, and special characters. | ||
| """ | ||
| is_valid_password = False | ||
| is_valid_password_check1 = False | ||
| is_valid_password_check2 = False |
There was a problem hiding this comment.
passes_sequence_repetition_check = False
There was a problem hiding this comment.
Updated the code accordingly.
| for password_regex in password_regexs: | ||
| if password_regex.match(password): | ||
| is_valid_password = True | ||
| is_valid_password_check1 = True | ||
| break | ||
|
|
There was a problem hiding this comment.
if not meets_character_requirements:
self.log("Password failed character type and length validation.", "ERROR")
There was a problem hiding this comment.
Updated the code accordingly.
| if not is_valid_password: | ||
| self.log("Checking that the password does not contain repetitive or sequential characters.", "DEBUG") | ||
| if re.match(password_sequence_repetitive_regex, password): | ||
| is_valid_password_check2 = True |
There was a problem hiding this comment.
passes_sequence_repetition_check = True
self.log("Password passed repetitive and sequential character checks.", "INFO")
else:
self.log("Password failed repetitive or sequential character validation.", "ERROR")
There was a problem hiding this comment.
Updated the code accordingly.
There was a problem hiding this comment.
Also tested the changes Madhan
madhansansel
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The below issue is fixed
1 Incorrect error message, for bad password.
Type of Change
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers