Device Config backup workflow module #382
Conversation
| @@ -394,6 +398,11 @@ class Device_configs_backup(DnacBase): | |||
| def __init__(self, module): | |||
| super().__init__(module) | |||
| self.skipped_devices_list = [] | |||
| self.payload = module.params | |||
| self.keymap = {} | |||
| self.dnac_version = int(self.payload.get( | |||
There was a problem hiding this comment.
setting dnac version is already done in dnac.py.. Can you check?
https://github.com/madhansansel/dnacenter-ansible/blob/main/plugins/module_utils/dnac.py
self.payload = module.params
self.dnac_version = int(self.payload.get("dnac_version").replace(".", ""))
# Dictionary to store multiple versions for easy maintenance and scalability
# To add a new version, simply update the 'dnac_versions' dictionary with the new version string as the key
# and the corresponding version number as the value.
self.dnac_versions = {
"2.3.5.3": 2353,
"2.3.7.6": 2376,
"2.2.3.3": 2233
# Add new versions here, e.g., "2.4.0.0": 2400
}
# Dynamically create variables based on dictionary keys
for version_key, version_value in self.dnac_versions.items():
setattr(self, "version_" + version_key.replace(".", "_"), version_value)
| site_exists = True | ||
| else: | ||
| self.log("No response received from the 'get_site' API call.", "WARNING") | ||
| response = self.get_site(site_name) |
There was a problem hiding this comment.
We don't need this API at all. Check get_site_id API and use it.. if you need site_exists also, then change the get_site_id API
There was a problem hiding this comment.
Removed that API and directly using get_site_id
There was a problem hiding this comment.
We can directly use get_site_id rite?
Why do we use get_site first, and use get the site id from the response?
There was a problem hiding this comment.
I removed and using get_site_id directly
There was a problem hiding this comment.
We still don't need this API. What is the purpose of the API?
| self.status = "failed" | ||
| self.msg = ("An exception occurred: Site '{0}' does not exist in the Cisco Catalyst Center.".format(site_name)) | ||
| self.result['response'] = self.msg | ||
| self.log(self.msg, "ERROR") | ||
| self.check_return_status() | ||
|
|
||
| return (site_exists, site_id) | ||
|
|
||
| def get_device_ids_from_site(self, site_name, site_id): |
There was a problem hiding this comment.
Move this API to dnac.py and make it common....
There was a problem hiding this comment.
Moved, I added two functions in dnac.py: one for getting device IDs from a site and another for retrieving the IP address from a device id.
| self.log("Reachable devices not found at Site: {0}".format(site_name), "WARNING") | ||
| self.msg = "No reachable devices found at Site: {0}".format(site_name) | ||
| self.update_result("ok", False, self.msg, "INFO") | ||
| self.module.exit_json(**self.result) |
There was a problem hiding this comment.
Why do we need to exit from the module if devices not found at site?
There was a problem hiding this comment.
If the device ID is not available, then the IP address cannot be retrieved in this task
Description
Update the Device backup config workflow module to support for replacement of APIs, and improved functionality with version-based routing.
Type of Change
Checklist
Ansible Best Practices
ansible-vaultor environment variables)Documentation
Screenshots (if applicable)
Notes to Reviewers