1 Bug Fix - Network Compliance Module #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest changes - June 4th, 2024
madhansansel
reviewed
Jun 5, 2024
| @@ -607,6 +607,10 @@ def get_device_ids_from_ip(self, ip_address_list): | |||
| except Exception as e: | |||
| # Log an error message if any exception occurs during the process | |||
| self.log("Error while fetching device ID for device: '{0}' from Cisco Catalyst Center: {1}".format(device_ip, str(e)), "ERROR") | |||
| if not mgmt_ip_instance_id_map: | |||
| self.msg = "Reachable devices not found in the IP Address List: {0}".format(ip_address_list) | |||
There was a problem hiding this comment.
Can we split the ip addresses using .join ? Can you check in our code?
formatted_ip_list = ', '.join(ip_address_list)
self.msg = "No reachable devices found among the provided IP addresses: [{}]".format(formatted_ip_list)
There was a problem hiding this comment.
will address this in the next PR.
madhansansel
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Code changes have been made to plugins/modules/network_compliance_workflow_manager.py file only.
Includes 1 Bug Fix:
Tested on Catalyst Centre v2.3.7.0.