Changes for typos, fixed CIDR issue and added delete all feature

[abimishr]

Problem description:

1. CIDR based discovery should have Ip passed as IP/{prefix length} instead of passing prefix length separately.
2. Coding error in the for loop of multi range discovery
3. Deletion of all the discoveries at one go

Fix: For te fix we have added / based string formation, have taken care of for loop based issues and delete_all is a new parameter that can delete all the discoveries if someone tries to delete all the discoveries

Test cases: Have tested delete all, single deletion and CIDR based discovery

[madhansansel]

Line 370 we checked state is merged. If state is merged, then we do comparision in line 375 as well. Instead can we write below?

        if state == "merged":
            discovery_spec["ip_address_list"] = {'type': 'list', 'required': True,
                                                 'elements': 'str'}
            discovery_spec["discovery_type"] = {'type': 'str', 'required': True}
        else if state == deleted:
            if (self.config[0].get("delete_all") is True:
                self.validated_config = [{"delete_all": True}]
                 self.msg = "Sucessfully collected input for deletion of all the discoveries"
                 self.log(self.msg, "WARNING")
                 return self

[abimishr]

Done

[madhansansel]

Can we give a warning message? Say that prefix length is not given, hence taking 30 as default..

[abimishr]

Done

[madhansansel]

Successfully deleted discovery.

[abimishr]

Done

[madhansansel]

Any reasons for this
state=state ?

[abimishr]

We are passing the state value here to use in the validation part

[madhansansel]

but why do we need to assign state = state when we call the function?

[abimishr]

Will it work if I don't pass the state?

[madhansansel]

If the 'state' is merged, there is no possibility for the state to be "deleted". Therefore, it is more efficient to use "elif" instead. By using two "if" statements, we unnecessarily perform the state comparison twice…

 if state == "merged":
            discovery_spec["ip_address_list"] = {'type': 'list', 'required': True,
                                                 'elements': 'str'}
            discovery_spec["discovery_type"] = {'type': 'str', 'required': True}
elif state == "deleted":

[abimishr]

Done

[madhansansel]

can we add bit more detail?
self.log("CIDR notation is being used for discovery and it requires a prefix length to be specified, such as 1.1.1.1/24. As no prefix length was provided, it will default to 30.", "WARNING")

[madhansansel]

elif discovery_type == "CIDR":
    if len(ip_address_list) == 1:
        cidr_notation = ip_address_list[0]

        if len(cidr_notation.split("/")) == 2:
            # If CIDR notation is used and prefix length is provided
            ip_address_list = cidr_notation
        else:
            # If CIDR notation is used but prefix length is not given, default to 30
            ip_address_list = f"{cidr_notation}/30"
            self.log("CIDR notation is being used for discovery and it requires a prefix length to be specified, such as 1.1.1.1/24. As no prefix length was provided, it will default to 30.", "WARNING")
    else:
        # Handle error if multiple IP addresses are provided for CIDR discovery
        self.preprocess_device_discovery_handle_error()

[abimishr]

Done