FNAMF: Fix video playback speed and audio buffer starvation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madewokherd
reviewed
Jun 3, 2024
madewokherd
reviewed
Jun 3, 2024
Recursively call tf_readaudio until dst_count is full.
|
I tested in One Finger Death Punch and got a crash in winegstreamer. Maybe because I'm using winehq? |
|
Oh, yeah, I probably don't have the needed video codecs in 32-bit gstreamer. |
|
Tested successfully, thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
The doubled video playback speed was the result of the variable
numframesbeing checked prior to decrementing, resulting in two samples being requested instead of one.The audio buffer starvation resulted, for example, when the requested buffer size was for 8192 samples, but only 256 samples arrived from the provided MF sample.
The PR:
numframesprior to checking the value; andThis fixes the playback (both audio and video) of the ending video in One Finger Death Punch (264200), and the audio for the logos in Hell Yeah! Wrath of the Dead Rabbit (205230).