Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to copy files instead of move them #41

Open
ehannes opened this issue May 3, 2021 · 3 comments
Open

Add option to copy files instead of move them #41

ehannes opened this issue May 3, 2021 · 3 comments

Comments

@ehannes
Copy link
Contributor

ehannes commented May 3, 2021

Hi!

I know there's been a lot back and forth about the move/copy strategy in this package. But we have some sites that has a lot of images. These sites more or less doubles in size when copying the assets instead of moving them, which gives us different problems.

Would you accept a pull request adding the option to copy instead of moving, and that we default to copying?
@raurir
Copy link
Contributor

raurir commented May 5, 2021

you mean "adding the option to move instead of copying"?

@ehannes
Copy link
Contributor Author

ehannes commented May 19, 2021

@raurir sorry, yes that's what I meant :)

@raurir
Copy link
Contributor

raurir commented May 24, 2021

Sure thing, make sure to add a test case for this.

Thanks.

ehannes added a commit to ehannes/gatsby-plugin-asset-path that referenced this issue Jun 10, 2021
@ehannes
Adds copyAssets option, relates to madecomfy#41
2f35fb5 
This is a first try to add a `copyAssets` option, which you can set to
`false` and then get your assets moved instead of copied. Sometimes,
that's what you want.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raurir @ehannes