review init #3

apoorvsadana · 2024-04-11T13:30:54Z

Reverts #2

src/main.rs

src/utils/deploy_utils.rs

src/utils/arg_config.rs

src/utils/utils.rs

src/snos/lib.rs

src/bridge_deploy_utils/lib.rs

src/bridge_deploy_utils/lib/utils.rs

src/bridge_deploy_utils/lib/constants.rs

src/main.rs

src/bridge/deploy_eth_bridge.rs

src/bridge/helpers/eth_bridge.rs

apoorvsadana · 2024-04-13T18:33:19Z

src/utils/constants.rs

let's remove all unused constants

move the constants used for tests in a new constants folder inside tests, otherwise it will create confusion. also, ig some constants like SN_GOERLI_CHAIN_ID, SPEC_VERSION, ANVIL_DEFAULT_PUBLIC_ADDRESS aren't being used

src/bridge/helpers/deploy_utils.rs

src/felt/lib.rs

src/bridge/contract_clients/config.rs

src/main.rs

src/bridge/contract_clients/config.rs

apoorvsadana · 2024-04-15T18:35:19Z

src/utils/eth_bridge.rs

+
+        sleep(Duration::from_secs(7)).await;
+
+        let address = get_contract_address_from_deploy_tx(&rpc_provider_l2, deploy_tx).await.expect("Error getting contract address from transaction hash");


did you check this?

src/bridge/contract_clients/eth_bridge.rs

src/bridge/deploy_erc20_bridge.rs

src/main.rs

apoorvsadana · 2024-04-15T18:40:55Z

src/main.rs

+    println!("{:?}", &args);
+
+    // args config
+    let config = ArgConfig::new(&args).unwrap_or_else(|err| {


how, we can just pass CliArgs? it's the same thing right?

src/tests/helpers.rs

apoorvsadana · 2024-04-15T18:44:09Z

src/utils/constants.rs

move the constants used for tests in a new constants folder inside tests, otherwise it will create confusion. also, ig some constants like SN_GOERLI_CHAIN_ID, SPEC_VERSION, ANVIL_DEFAULT_PUBLIC_ADDRESS aren't being used

Revert "delete all"

ff6a8c0

apoorvsadana changed the title ~~Revert "delete all"~~ review init Apr 11, 2024

apoorvsadana commented Apr 11, 2024

View reviewed changes

ocdbytes added 2 commits April 12, 2024 17:01

feat : changes commit 1

2e78d52

feat : added wait for transaction

a351293

apoorvsadana commented Apr 13, 2024

View reviewed changes

ocdbytes added 2 commits April 15, 2024 23:12

feat : updated the code : added env support

1d069f4

feat : updated the code : added env support

515f998

apoorvsadana commented Apr 15, 2024

View reviewed changes

feat : added workflow files

46a5e33

apoorvsadana commented Apr 15, 2024

View reviewed changes

ocdbytes added 4 commits April 16, 2024 01:05

updated : review changes

cb76d46

feat : updated the code : added github actions

d2fefa3

feat : added contract repository

6515678

feat : lint fix : tests

aefef8d

ocdbytes merged commit 3a50b82 into main Apr 16, 2024
5 checks passed

ocdbytes deleted the revert-2-delete_all branch April 16, 2024 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

review init #3

review init #3

apoorvsadana commented Apr 11, 2024

apoorvsadana Apr 13, 2024

apoorvsadana Apr 15, 2024

apoorvsadana Apr 15, 2024

apoorvsadana Apr 15, 2024

apoorvsadana Apr 15, 2024


		sleep(Duration::from_secs(7)).await;

		let address = get_contract_address_from_deploy_tx(&rpc_provider_l2, deploy_tx).await.expect("Error getting contract address from transaction hash");

review init #3

review init #3

Conversation

apoorvsadana commented Apr 11, 2024

apoorvsadana Apr 13, 2024

Choose a reason for hiding this comment

apoorvsadana Apr 15, 2024

Choose a reason for hiding this comment

apoorvsadana Apr 15, 2024

Choose a reason for hiding this comment

apoorvsadana Apr 15, 2024

Choose a reason for hiding this comment

apoorvsadana Apr 15, 2024

Choose a reason for hiding this comment