Log process id #54
Merged
Log process id #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea. This could be really useful. |
|
nice work |
|
I can already see all the complaints about it not compiling on everybodys machine, can you surround that with an |
26 tasks
|
I haven't tested on Windows yet, but the API seems to point that it returns a DWORD, so it must work. |
madMAx43v3r
reviewed
Jun 9, 2021
madMAx43v3r
reviewed
Jun 9, 2021
src/chia_plot.cpp
Outdated
| #include <processthreadsapi.h> | ||
| #define GETPID GetCurrentProcessId | ||
| #else | ||
| #define GETPID |
There was a problem hiding this comment.
that won't compile, how about: #define GETPID() int(-1)
There was a problem hiding this comment.
My apologies, I haven't tested it so I had no idea about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this needs any description